solution #2615
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,30 +1,62 @@ | ||
| import React, { useState } from 'react'; | ||
|
|
||
| type Props = { | ||
| onSelect: (value: string) => void; | ||
| onChange: (value: string) => void; | ||
| }; | ||
|
There was a problem hiding this comment. The naming convention for event handler props should follow the pattern 'on'. Consider renaming 'onChange' to something more descriptive like 'onInputChange' to clearly indicate what event it handles. |
||
|
|
||
| export const TodoFilter: React.FC<Props> = ({ onSelect, onChange }) => { | ||
| const [value, setValue] = useState(''); | ||
| const inputHandler: React.ChangeEventHandler<HTMLInputElement> = event => { | ||
| onChange(event.target.value); | ||
| setValue(event.target.value); | ||
| }; | ||
|
|
||
| const resetInputHandler = () => { | ||
| onChange(''); | ||
| setValue(''); | ||
| }; | ||
|
|
||
| return ( | ||
| <form className="field has-addons"> | ||
| <p className="control"> | ||
| <span className="select"> | ||
| <select | ||
| data-cy="statusSelect" | ||
| onChange={event => onSelect(event.target.value)} | ||
| > | ||
|
There was a problem hiding this comment. The inline function for the 'onChange' event of the select element could lead to performance issues as a new function is created on every render. Consider defining this function outside the JSX and passing it as a reference. |
||
| <option value="all">All</option> | ||
| <option value="active">Active</option> | ||
| <option value="completed">Completed</option> | ||
| </select> | ||
| </span> | ||
| </p> | ||
|
|
||
| <p className="control is-expanded has-icons-left has-icons-right"> | ||
| <input | ||
| data-cy="searchInput" | ||
| type="text" | ||
| className="input" | ||
| placeholder="Search..." | ||
| value={value} | ||
| onChange={inputHandler} | ||
| /> | ||
| <span className="icon is-left"> | ||
| <i className="fas fa-magnifying-glass" /> | ||
| </span> | ||
|
|
||
| {value && ( | ||
| <span className="icon is-right" style={{ pointerEvents: 'all' }}> | ||
| {/* eslint-disable-next-line jsx-a11y/control-has-associated-label */} | ||
| <button | ||
| data-cy="clearSearchButton" | ||
| type="button" | ||
| className="delete" | ||
| onClick={resetInputHandler} | ||
| /> | ||
| </span> | ||
| )} | ||
| </p> | ||
| </form> | ||
| ); | ||
| }; | ||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,100 +1,77 @@ | ||
| import React from 'react'; | ||
| import { Todo } from '../../types/Todo'; | ||
| import classNames from 'classnames'; | ||
|
|
||
| interface Props { | ||
| todos: Todo[]; | ||
| selectedTodo: Todo | undefined; | ||
| onSelect: (todo: Todo) => void; | ||
| } | ||
|
|
||
| export const TodoList: React.FC<Props> = ({ | ||
| todos, | ||
| selectedTodo: { id: selectedId } = { selectedId: 0 }, | ||
|
There was a problem hiding this comment. Using destructuring with default values for |
||
| onSelect, | ||
| }) => { | ||
| return ( | ||
| <table className="table is-narrow is-fullwidth"> | ||
| <thead> | ||
| <tr> | ||
| <th>#</th> | ||
| <th> | ||
| <span className="icon"> | ||
| <i className="fas fa-check" /> | ||
| </span> | ||
| </th> | ||
| <th>Title</th> | ||
| <th></th> | ||
| </tr> | ||
| </thead> | ||
|
|
||
| <tbody> | ||
| {todos.map(({ id, title, completed, userId }) => ( | ||
| <tr | ||
| data-cy="todo" | ||
| className={`${id === selectedId && 'has-background-info-light'}`} | ||
|
There was a problem hiding this comment. Consider using the |
||
| key={id} | ||
|
There was a problem hiding this comment. Generating keys directly from the |
||
| > | ||
| <td className="is-vcentered">{id}</td> | ||
| <td className="is-vcentered"> | ||
| {completed && ( | ||
| <span className="icon" data-cy="iconCompleted"> | ||
| <i className="fas fa-check" /> | ||
| </span> | ||
| )} | ||
| </td> | ||
| <td className="is-vcentered is-expanded"> | ||
| <p | ||
| className={` | ||
| ${completed ? 'has-text-success' : 'has-text-danger'} | ||
| `} | ||
| > | ||
| {title} | ||
| </p> | ||
| </td> | ||
| <td className="has-text-right is-vcentered"> | ||
| <button | ||
| data-cy="selectButton" | ||
| className="button" | ||
| type="button" | ||
| onClick={() => onSelect({ id, title, completed, userId })} | ||
| > | ||
| <span className="icon"> | ||
| <i | ||
| className={classNames( | ||
| 'far', | ||
| selectedId === id ? 'fa-eye-slash' : 'fa-eye', | ||
| )} | ||
| /> | ||
| </span> | ||
| </button> | ||
| </td> | ||
| </tr> | ||
| ))} | ||
| </tbody> | ||
| </table> | ||
| ); | ||
| }; | ||
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The state setter function here is named
setSelectedQuery, but it should besetQueryto match the state variable namequery. This follows the naming convention for state setter functions.