add task solution #2628
add task solution #2628
Conversation
There was a problem hiding this comment.
Great job on implementing the main functionality of the application! 🎉 The code is well-structured and meets most of the task requirements. There are a couple of minor issues to address, such as integrating the classnames library for conditional class definitions and refining the Loader component logic. Keep up the good work and consider these improvements for future projects! 😊
✨ Please rate this review in the Platform's notification center. I will be grateful for your feedback! ✨
| {todos.length === 0 ? ( | ||
| <Loader /> |
There was a problem hiding this comment.
The Loader component is displayed when todos.length === 0. This logic might cause the loader to appear even when there are no todos to fetch or display. Consider checking if the data is still being fetched to conditionally render the Loader component.
|
|
||
| interface Props { | ||
| todo: Todo | null; | ||
| setModalOpen: (val: boolean) => void; |
There was a problem hiding this comment.
The setModalOpen function is expected to take a boolean value, but in the handleCloseModal function, it is called with false. Ensure that this aligns with the intended functionality, as the function signature suggests it should be used to open or close the modal.
DEMO LINK