matemenu-tree: Fix crash when adding launcher from compact menu #117
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The emit_changed_signal callback was attempting to run on a submenu that had already been destroyed by its parent menu. Closes mate-desktop#116
lukefromdc
reviewed
Jan 10, 2024
|
I can confirm that using this PR drop the valgrind output from #116 (comment) when adding a launcher. |
|
We need to recheck why author and reviewers get different results. From my point of view PR looks good. |
|
@zhuyaliang |
raveit65
approved these changes
Jan 14, 2024
|
@lukefromdc |
lukefromdc
reviewed
Jan 24, 2024
|
same crash in x11 too. Note that I am running locally compiled GTK 3.24.39 with the gtk3-classic patches applied and locally compiled glib 2.78.3 |
I am still wondering about the crash description. |
|
I see only this in terminal: Also with valigrind i do not see your message. |
|
I saw it in terminal after running |
|
Weird, that we get different outputs in terminal. |
|
@cwendling |
|
@lukefromdc any chance we could get a GDB backtrace or Valgrind report when it happens? |
|
I got this from |
|
I got this backtrace from gdb: |
|
Can you check that the compiled mate-menus library is being used when you run
I'm wondering if there's an issue with |
|
libmate-menu.so.2 => /lib/x86_64-linux-gnu/libmate-menu.so.2 (0x00007f1e2add0000) Note that I have all of MATE locally compiled, my Checkinstall(for autotools) or DESTDIR (for meson) .deb files install to the exact same locations as my direct installs. |
|
@cwendling |
|
I didn't get any NEW problems with this, it just didn't fix an existing problem. If these are two different crashes, than not fixing one is no reason not to fix the other. I've had this installed from last build for a while with same behavior as master on my system. |
|
Thx. |
|
@lukefromdc |
|
It most certainly did, and continued to do so after I added the second commit to mate-desktop/mate-panel#1434 to return to GtkImageMenuItem (already referred to in the header file after the revert) for the Places and System main menu items |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
emit_changed_signalcallback was attempting to run on a submenu that had already been destroyed by its parent menu.Closes #116
Testing
mate-panel --replace