Check the existence of dconf-editor's schema #1447

City-busz · 2024-06-20T01:22:57Z

We need to check the existence of dconf-editor's GSettings schema before using it, because the program will abort if dconf-editor is not installed on the system when it tries to access it.

libmate-panel-applet/mate-panel-applet-gsettings.c

mate-panel/panel-profile.c

We need to check the existence of dconf-editor's GSettings schema before using it, because the program will abort if dconf-editor is not installed on the system when it tries to access it.

cwendling · 2024-06-20T08:53:07Z

Not tested, but makes sense 👍

lukefromdc

This builds and runs fine, and it does indeed let mate-panel run without dconf-editor installed. This removes a pesky unreported dependency, at least in Debian dconf-editor is NOT listed as a dependency but the panel without this change won't run without it.

The checking code is similar to what is used to look for the GNOME schemas read by wayland compositors in mate-control-center's appearance capplet and in wayland sessions load them if and only if present.

lukefromdc · 2024-06-20T23:31:26Z

Anyone else want to review this before merging? This is a bugfix and in my opinion is another one worth cherrypicking to 1.28 and thankfully, this time around the issue this fixes didn't get introduced until 1.27 and never made it into 1.26

lukefromdc · 2024-07-16T02:22:55Z

Any updates on this? This is something we really need to get done, as we have in 1.28 as it stands a new and unreported dependency on dconf-editor that could hand a lot of users an ugly surprise. Most won't know the reason their panel just keeps crashing is that they don't have dconf-editor installed.

It seems ready to go though we haven't gotten any reviews. Should I go ahead and merge this or not?

thesquash

Looks good to me. I was just about to fix this in my own PR when I saw this.

Sorry, I've been away for months due to terrible illness.

lukefromdc · 2024-10-15T18:35:31Z

No problem, thanks for reviewing and merging when you could.

lukefromdc · 2024-10-15T18:42:08Z

We have this Travis error that will probably block a new release of 1.28 carrying this fix from deploying. I do NOT know how to fix these Travis problems or know Ruby at all:

$ if [[ "$TRAVIS_SECURE_ENV_VARS" == "true" && "$TRAVIS_PULL_REQUEST" != "false" && ${DISTRO} =~ ^fedora.*$ ]]; then REPO_SLUG_ARRAY=(${TRAVIS_REPO_SLUG//// }); REPO_NAME=${REPO_SLUG_ARRAY[1]}; URL="https://${REPO_NAME}.mate-desktop.dev"; COMMENT="Code analysis completed"; curl -H "Authorization: token $GITHUB_TOKEN" -X POST -d "{"state": "success", "description": "$COMMENT", "context":"scan-build", "target_url": "$URL"}" https://api.github.com/repos/${TRAVIS_REPO_SLUG}/statuses/${TRAVIS_PULL_REQUEST_SHA}; fi
dpl_0

$ rvm use $(travis_internal_ruby) --fuzzy do ruby -S gem uninstall -aIx dpl

/home/travis/.rvm/gems/ruby-3.3.5/gems/cl-1.2.4/lib/cl/opts.rb:112:in `block in taint': undefined method `taint' for an instance of String (NoMethodError)

          [key, self[key] && self[key].secret? ? value.taint : value]

                                                      ^^^^^^

	from /home/travis/.rvm/gems/ruby-3.3.5/gems/cl-1.2.4/lib/cl/opts.rb:111:in `each'

	from /home/travis/.rvm/gems/ruby-3.3.5/gems/cl-1.2.4/lib/cl/opts.rb:111:in `map'

	from /home/travis/.rvm/gems/ruby-3.3.5/gems/cl-1.2.4/lib/cl/opts.rb:111:in `taint'

	from /home/travis/.rvm/gems/ruby-3.3.5/gems/cl-1.2.4/lib/cl/opts.rb:25:in `apply'

	from /home/travis/.rvm/gems/ruby-3.3.5/gems/cl-1.2.4/lib/cl/cmd.rb:62:in `initialize'

	from /home/travis/.rvm/gems/ruby-3.3.5/gems/dpl-2.0.3.beta.4/lib/dpl/provider.rb:196:in `initialize'

	from /home/travis/.rvm/gems/ruby-3.3.5/gems/cl-1.2.4/lib/cl/runner/default.rb:32:in `new'

	from /home/travis/.rvm/gems/ruby-3.3.5/gems/cl-1.2.4/lib/cl/runner/default.rb:32:in `cmd'

	from /home/travis/.rvm/gems/ruby-3.3.5/gems/cl-1.2.4/lib/cl/runner/default.rb:26:in `run'

	from /home/travis/.rvm/gems/ruby-3.3.5/gems/cl-1.2.4/lib/cl.rb:34:in `run'

	from /home/travis/.rvm/gems/ruby-3.3.5/gems/dpl-2.0.3.beta.4/lib/dpl/cli.rb:11:in `run'

	from /home/travis/.rvm/gems/ruby-3.3.5/gems/dpl-2.0.3.beta.4/bin/dpl:9:in `<top (required)>'

	from /home/travis/.rvm/gems/ruby-3.3.5/bin/dpl:25:in `load'

	from /home/travis/.rvm/gems/ruby-3.3.5/bin/dpl:25:in `<main>'

failed to deploy

We need to check the existence of dconf-editor's GSettings schema before using it, because the program will abort if dconf-editor is not installed on the system when it tries to access it.

lukefromdc · 2024-10-15T18:54:39Z

Cherrypicked to 1.28

lukefromdc · 2024-10-15T19:26:42Z

We need someone to fix the Travis issue blocking deployments or show me how to do it so I or someone else can release 1.28.3 so distros can pick this up. Until then, I would advise distrops to apply this patch especially if they don't want to ship dconf-editor or want to use an older version of it that uses the original interface

lukefromdc · 2024-10-15T19:37:14Z

15de78f
Had no effect on this particular Travis problem, it had fixed a problem in another repo but didn't work here. The Debian build finishes fine, we deploy from Fedora which errored out on the part of the deployment which runs before determining whether to push a tarball to the releases page with this error again:


$ rvm use $(travis_internal_ruby) --fuzzy do ruby -S gem uninstall -aIx dpl

/home/travis/.rvm/gems/ruby-3.3.5/gems/cl-1.2.4/lib/cl/opts.rb:112:in `block in taint': undefined method `taint' for an instance of String (NoMethodError)

          [key, self[key] && self[key].secret? ? value.taint : value]

                                                      ^^^^^^

	from /home/travis/.rvm/gems/ruby-3.3.5/gems/cl-1.2.4/lib/cl/opts.rb:111:in `each'

	from /home/travis/.rvm/gems/ruby-3.3.5/gems/cl-1.2.4/lib/cl/opts.rb:111:in `map'

	from /home/travis/.rvm/gems/ruby-3.3.5/gems/cl-1.2.4/lib/cl/opts.rb:111:in `taint'

	from /home/travis/.rvm/gems/ruby-3.3.5/gems/cl-1.2.4/lib/cl/opts.rb:25:in `apply'

	from /home/travis/.rvm/gems/ruby-3.3.5/gems/cl-1.2.4/lib/cl/cmd.rb:62:in `initialize'

	from /home/travis/.rvm/gems/ruby-3.3.5/gems/dpl-2.0.3.beta.4/lib/dpl/provider.rb:196:in `initialize'

	from /home/travis/.rvm/gems/ruby-3.3.5/gems/cl-1.2.4/lib/cl/runner/default.rb:32:in `new'

	from /home/travis/.rvm/gems/ruby-3.3.5/gems/cl-1.2.4/lib/cl/runner/default.rb:32:in `cmd'

	from /home/travis/.rvm/gems/ruby-3.3.5/gems/cl-1.2.4/lib/cl/runner/default.rb:26:in `run'

	from /home/travis/.rvm/gems/ruby-3.3.5/gems/cl-1.2.4/lib/cl.rb:34:in `run'

	from /home/travis/.rvm/gems/ruby-3.3.5/gems/dpl-2.0.3.beta.4/lib/dpl/cli.rb:11:in `run'

	from /home/travis/.rvm/gems/ruby-3.3.5/gems/dpl-2.0.3.beta.4/bin/dpl:9:in `<top (required)>'

correctmost · 2024-10-15T22:22:11Z

Here's an attempt to fix the Travis error: #1454

lukefromdc · 2024-10-17T05:43:50Z

1.28.4 is out, ready for distros

fulalas · 2024-10-19T12:20:24Z

You guys are amazing. About a year ago I opened an issue talking about this, and eventually wrote a patch to fix it, only to hear from you that you couldn't replicate the issue and that dconf-editor should be installed anyway.

Although better late than never, my suggestion is: don't become what GNOME is. Listening to people and having good sense is always the best path. :)

cwendling reviewed Jun 20, 2024

View reviewed changes

libmate-panel-applet/mate-panel-applet-gsettings.c Outdated Show resolved Hide resolved

cwendling reviewed Jun 20, 2024

View reviewed changes

mate-panel/panel-profile.c Outdated Show resolved Hide resolved

Check the existence of dconf-editor's schema

d76b914

We need to check the existence of dconf-editor's GSettings schema before using it, because the program will abort if dconf-editor is not installed on the system when it tries to access it.

City-busz force-pushed the dconf-editor-schema-check branch from 1b0c558 to d76b914 Compare June 20, 2024 08:32

cwendling requested a review from a team June 20, 2024 08:53

lukefromdc approved these changes Jun 20, 2024

View reviewed changes

lukefromdc requested a review from a team June 20, 2024 23:27

thesquash approved these changes Oct 15, 2024

View reviewed changes

thesquash merged commit 609d1ba into mate-desktop:master Oct 15, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Check the existence of dconf-editor's schema #1447

Check the existence of dconf-editor's schema #1447

City-busz commented Jun 20, 2024

cwendling commented Jun 20, 2024

lukefromdc left a comment

lukefromdc commented Jun 20, 2024

lukefromdc commented Jul 16, 2024 •

edited

Loading

thesquash left a comment

lukefromdc commented Oct 15, 2024 •

edited

Loading

lukefromdc commented Oct 15, 2024

lukefromdc commented Oct 15, 2024

lukefromdc commented Oct 15, 2024 •

edited

Loading

lukefromdc commented Oct 15, 2024

correctmost commented Oct 15, 2024

lukefromdc commented Oct 17, 2024

fulalas commented Oct 19, 2024 •

edited

Loading

Check the existence of dconf-editor's schema #1447

Check the existence of dconf-editor's schema #1447

Conversation

City-busz commented Jun 20, 2024

cwendling commented Jun 20, 2024

lukefromdc left a comment

Choose a reason for hiding this comment

lukefromdc commented Jun 20, 2024

lukefromdc commented Jul 16, 2024 • edited Loading

thesquash left a comment

Choose a reason for hiding this comment

lukefromdc commented Oct 15, 2024 • edited Loading

lukefromdc commented Oct 15, 2024

lukefromdc commented Oct 15, 2024

lukefromdc commented Oct 15, 2024 • edited Loading

lukefromdc commented Oct 15, 2024

correctmost commented Oct 15, 2024

lukefromdc commented Oct 17, 2024

fulalas commented Oct 19, 2024 • edited Loading

lukefromdc commented Jul 16, 2024 •

edited

Loading

lukefromdc commented Oct 15, 2024 •

edited

Loading

lukefromdc commented Oct 15, 2024 •

edited

Loading

fulalas commented Oct 19, 2024 •

edited

Loading