Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enhancement(Navbar) implemented classname, hovering link color bug, #588

Open
wants to merge 3 commits into
base: v2-dev
Choose a base branch
from

Conversation

gselderslaghs
Copy link
Member

Proposed changes

Fixed todo in navbar by adding navbar class instead of targeting html tag, also fixes part of #573
Fixed #385 hovering link bug

Checklist:

  • I have read the CONTRIBUTING document.
  • My commit messages follows the conventional commit format
  • My change requires a change to the documentation, and updated it accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@gselderslaghs
Copy link
Member Author

Additionally made color and background color states important to fix specificity issue on same specificity level (eg. classname - classname)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant