-
Notifications
You must be signed in to change notification settings - Fork 94
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Advertising the atomate2 paper writing #750
Comments
I am very excited about this effort and happy to be involved! Apologies for not being able to make the last couple of meetings --- I've had some conflicts. In any case, @esoteric-ephemera shall I counter-nominate you for the MP workflow lead? 😉 Of course, I am happy to help write. |
@Andrew-S-Rosen Thanks for the nomination. I have put @esoteric-ephemera as the first name of the MP workflow. Hi @mjwen, since @utf and @JaGeo are the lead of a few workflows, are you interested in being the lead of the elastic workflow? |
@Zhuoying Yes, I'd be happy to! |
Thank you, @Zhuoying . Could you add @ab5424 to the harmonic phonon workflow as well? Thanks! The implemented workflow was based on a previous implementation in his Master thesis. (To mention shortly, I also only indirectly contributed to the FHI-aims implementation as it starts from the phonon workflow) |
Thanks very much for putting this message together @Zhuoying. I would just raise two additional points. Workflows vs CalculatorsI think we should make a distinction in the paper between workflows and force/energy calculators. Many of the workflows are agnostic to the choice of calculator (e.g., elastic, phonon, defect etc). I suggest we therefore have a section before workflows providing a short summary for each calculator. Welcoming additional contributionsThere are some contributors to atomate2 who have provided fixes here and there but who have not contributed to major workflows. I want to make it clear that these contributors are still welcome to be included on the atomate2 paper. However, we're suggesting that these people could contribute more to the atomate2 code base, either by fixing an open issue or by adding a new tutorial to the documentation. Currently, I think we could do with the following tutorials, however, if you have other ideas then please let me know.
If you think you could fit into this category, please reach out to me via email and we can chat. Notes on the contributor listLooking through the list, @ansobolev has also contributed to the FHI-aims implementation; @CompRhys added the MACE workflow; |
Very nice to see this issue open! Just adding @VicTrqt, @gmrigna and @gpetretto to the abinit workflows. |
Thanks @Andrew-S-Rosen and @Zhuoying! Might also suggest lumping the EOS workflows (WIP waiting on an emmet release) under the elastic flows. Would we want to put together an examples directory with jupyter / python notebooks showing typical use? Basically would just mean writing a script to reproduce the figure(s) that we add to the paper |
Thanks @Zhuoying for nominating me and @rkingsbury. This is a question to both @Zhuoying and @utf . For DFT code contributions, do we have a blueprint similar to the one for workflows? Or do we plan to have a generalized code-agnostic discussion in the paper? |
I'm happy to write about the FHI-aims and help out with the phonon workflow parts as well |
@JaGeo I wrote up part of the section for forcefields--could you add the relevant parts about phonons/elastic constants to it? We can figure out what kinds of workflow flowcharts we want to do offline (if that works for you) |
@rdguha1995 Good question. I think this would be a reasonable starting point:
I'll update the original message with this information. |
@matthewkuner @JaGeo @janosh what do you think about putting the force field part in the "Calculators" section rather than "Workflows" section. Since the force fields can be used for many workflows I think this makes sense, but happy to hear your thoughts. |
agreed! |
Fine with me! |
Sounds good to me |
@JaGeo Sure, it is a good point (always keep a clear organization for efficient communication in such a collaborative project). @Andrew-S-Rosen, I remember we already have a slack channel called atomate2-working-group created by you a while ago (for monthly meeting purposes). Would you mind using that slack channel (and inviting more contributors to the channel) for the communication? |
I always love when I solved my own problems without remembering 😆 will do! |
@Andrew-S-Rosen @ab5424 's mail address is in your mail 😅 |
@Andrew-S-Rosen I did not get an email ([email protected]) |
Hey everyone :) @utf, as we agreed, I will work on an atomate2 tutorial for "A high-level overview of the key concepts in atomate2: job/flow makers, input sets, task documents, and builders" to contribute to this paper :) |
@QuantumChemist please send me your email and I'll add you. :) |
Likewise, discussed with @utf and I will work on some tutorials describing the execution mechanisms (fireworks, JF local, JF remote etc) and would be happy to contribute to the paper. I would also like a slack invite please, hopefully you have my email! |
Hi all, thank you for including me in this effort. TBH, I would classify my contributions up to this point as mostly "moral support" to @rdguha1995 plus a few code reviews, so I'm not sure I should qualify as a coauthor (yet). That said, I'd be happy to work with @rdguha1995 on the Q-Chem calculator section and also to develop tutorials on one or both of the following:
Plus some tutorials on specific Q-Chem topics (although perhaps not relevant for the paper). @Andrew-S-Rosen can you please add me to the Slack? I either missed the invitation or did not get one. Is this a dedicated workspace or a channel in BerkeleyTheory or MP? |
Workflow template: Color for dynamic workflow included on the side. |
@jmmshn thank you! Awesome! And sorry to all for joining late. The session at the MRS before went over time (finally being in a time zone that made the meeting possible) |
Also missed due to MRS apologies, but will catch up from Janine.On Apr 26, 2024, at 11:02, J. George ***@***.***> wrote:
@jmmshn thank you! Awesome!
And sorry to all for joining late. The session at the MRS before went over time (finally being in a time zone that made the meeting possible)
—Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because you were mentioned.Message ID: ***@***.***>
|
Hi all, Here are the notes from Friday April 26 meeting: Needs to be completed!These are items that were not filled in at the time of needing and need urgently to be filled in
Needs to be updatedWe discussed Table 2 with the checkmarks. This table looks very sparse. Suggest to:
Suggest @janosh takes the lead or assigns to someone Needs to be homogenizedWe discussed the way figures should be formatted. The general consensus was to use the style of electrode insertion workflow in terms of color scheme / overall layout / level of detail of text. However some refinements to this style were also discussed:
Minor / TBD
|
i get nightmares from latex tables! just so you know what you're asking... jokes aside, i moved the most populated columns to the left (i.e. VASP) and merged the 4 ML columns (CHGNet, M3GNet, MACE, GAP) into 1 titled MLFFs (machine learning force fields), now explained in the caption (adding Nequip to the list). i added a checkmark for the MLFF column in the equation of state row which is already implemented. rather than order columns by checkmark density, maybe better to order by association e.g. |
Now that there's an MPMorph PR submitted (still WIP but should be ready around submission time), I'd like to nominate @BryantLi-BLI to co-lead the MPMorph write up. Bryant has led much of the rewrite of these workflows. @utf and @Zhuoying, I can send Bryant's contact info over slack
Should we clarify that the MLFF stuff is now rewritten so that any ASE calculator works in these flows? That's now true for the relax, static, and MD MLFF jobs AIMD and classical MD might be condensed into just MD (also think we're missing the AIMD implementations) |
Hi, sorry, I could not make to the meeting, so I have a few questions concerning these points:
Should these parts just be condensed in a single section? One potential issue is that classical MD is currently in the "Molecular systems" section, while AIMD is in the "Periodic systems" one. Where should the common section stay then?
Not sure why I was assigned the GW workflow. Is this correct? |
@gpetretto I think we were confused about the responsibilty for the GW workflows. As currently, the VASP and Abinit versions are build, we were not sure who would write it. Thus, it is really rather an open question who should be responsible. |
thanks @esoteric-ephemera, used triangles to indicate low implementation effort, circle for workflow-engine combos on atomate2's near-term road map (currently nothing, input welcome!) and combined the AIMD and classical MD rows into a single MD row. i put |
Just to mention it: LOBSTER could be run for a molecule with VASP as well. Abinit could likely be connected to the workflow as well but this would require some work from our side (a few days to.get lobsterin files for abinit). |
I have checked with @tatha0003, who is the author of the PR for the GW workflows for Abinit (#816). He would be interested to contribute the section for the GW workflow of the paper. Not sure if anyone that wrote the VASP implementation is interested. |
@naik-aakash has now updated the figures on the LOBSTER and Phonon workflow. If there is already feedback, let us know. Otherwise, we will wait for the next meeting. |
Hi all, |
Hi @JaGeo I will try to complete the abinit GW and BSE workflow section by the end of this week. |
Thank you, @tatha0003 ! 😀 |
Hi there! I'd like to update the FE workflow picture. What's the right template to use? Thanks |
@fraricci : #750 (comment) :) |
Hi everyone, these are the notes from the meeting on the 3rd June. MD section
MPMorph
GW/Excited states
VASP calculator section
Table 2
Workflow diagrams
Timeframe
|
Sure, glad to contribute! |
2 questions regarding this item -
|
Hey @rkingsbury! I agree. I think when I was writing that section, a figure for each calculator was preferred. I can go ahead and remove that. @rohithsrinivaas - Can you coordinate with Ryan on the FFOpt workflow figure? In my opinion, it would be easiest for Rohith to adapt it into the current template. |
@rkingsbury I have updated the overleaf document with workflow diagram, adapting it to the current template. The pptx is in atomate2/figures_pptx_versions in the overleaf |
Thanks very much @rohithsrinivaas ! |
The paper is looking good! I made minor edits to the Q-Chem sections this morning. I don't expect to have further input before submission (but will happily iterate on the tutorial referenced above and answer any questions). It's unlikely I'll be able to attend the meeting tomorrow. |
I will also not be able to make it to the meeting tomorrow. I will have a chat with @rohithsrinivaas about the meeting minutes if this is the final one before we submit and I am happy to contribute to any further edits and future revisions. Fingers crossed and Best of Luck for the submission Team! 🤞 |
Adding a brief note that I met some researchers from University of Colorado, Boulder and NREL who are developing a JDFTx workflow for atomate2 (supports grand canonical DFT for electrochemistry), expecting PR relatively soon. I realise this will not be in time for submission, but perhaps during revision if this work is sufficiently advanced by then? In either case wanted to mention it so that it's on the radar. |
I'm reviewing the current draft and wondering if anyone has a list of workflows that are present in atomate1 that have not yet been ported to atomate2? |
Dear contributors,
We are thrilled to share the commencement of the Atomate2 paper's preparation phase. Our goal is to have the initial draft ready by our upcoming monthly gathering on March 29.
Since Atomate2 is truly a collective endeavor, we want to ensure that every contributor has the opportunity to contribute to the paper (including those who have made minor contributions but would like to do more to qualify for authorship).
Overview
The paper will be split into 5 sections:
Below, you will find a list of teams categorized according to their workflow and calculator code contributions, compiled to the best of my knowledge. Should there be any oversight or additional workflows you've contributed to that are not mentioned, please do not hesitate to bring them to our attention.
Calculators
We kindly ask each calculator team to prepare the following:
Workflows
We kindly ask each workflow team to prepare the following:
Welcoming Additional Contributors
There are some contributors to atomate2 who have provided fixes here and there but who have not contributed to major workflows. We want to make it clear that these contributors are still welcome to be included on the atomate2 paper. However, we're suggesting that these people could contribute more to the atomate2 code base, either by fixing an open issue or by adding a new tutorial to the documentation. Currently, we could do with the following tutorials, however, if you have other ideas then please let @utf know.
If you think you could fit into this category, please reach out to @utf via email and we can chat.
List of tutorial contributors: @QuantumChemist, @ml-evs, @JonathanSchmidt1, @naik-aakash, @JaGeo
Notes
We are delighted to hear your thoughts. For example, if you think anyone should be added to the authorship but not currently listed, don't hesitate to let us know.
You are encouraged to collaborate within or across teams as you see fit. To simplify the collecting process, we propose nominating the first person listed in each workflow as the team leader by default. However, please feel free to adjust the leadership roles within your teams or to merge different workflow teams if you find it necessary. If any changes occur, we would appreciate a brief notification. I will make ongoing updates to the workflow list based on your feedback for a better track.
Point of contact for accessing collaboration platforms
Overleaf: Please leave your email to @utf for access to our Overleaf project.
Zoom meeting: Please leave your email to @Zhuoying for the Google invite (our next meeting will be 8:30 AM on March 29 PST to discuss jobflow-remote and the paper writing)
Slack channel: Please leave your email to @Andrew-S-Rosen for the Slack invite.
Your contributions are greatly valued. Any of your feedback and thoughts are welcome!
The text was updated successfully, but these errors were encountered: