Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix python = 3.12 incompatibility #120

Merged
merged 5 commits into from
Oct 22, 2024
Merged

Fix python = 3.12 incompatibility #120

merged 5 commits into from
Oct 22, 2024

Conversation

kavanase
Copy link
Contributor

@kavanase kavanase commented Sep 24, 2024 •
edited
Loading

Small fix to allow python=3.12 compatibility, as pkg_resources has now been fully deprecated:
mu-editor/mu#2485

Contributor Checklist

  • I have broken down my PR scope into the following TODO tasks
    • task 1
    • task 2
  • I have run the tests locally and they passed.
  • I have added tests, or extended existing tests, to cover any new features or bugs fixed in this PR

@kavanase
Copy link
Contributor Author

The failing tests are due to other updates external to this fix

@kavanase
Copy link
Contributor Author

kavanase commented Oct 8, 2024

Just bumping this. This code should fix the issue, which is still causing our tests to fail

@kavanase kavanase mentioned this pull request Oct 22, 2024
Merged
@tschaume tschaume merged commit 43351ff into materialsproject:main Oct 22, 2024
4 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kavanase @tschaume