Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adding the sum topology #1368

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

adding the sum topology #1368

wants to merge 2 commits into from

Conversation

zstone1
Copy link
Contributor

@zstone1 zstone1 commented Oct 28, 2024

Another preliminary for #1350, this adds the very basic topology for sums. There are a lot of results about sums that are missing, of course. Sums preserve uniform and pseudometric structures, and basically all the local properties. But for now I just provide what I need for homotopy theory.

Annoyingly, there is a call to the non-ssreflect tactic destruct here, when dealing with dependent equalities. When I have a fact that i = j, then form existT P i x = existT P j y should produce a x = y. I could not figure how to do this. If the destruct tactic is forbidden, then how should I remove it?

Checklist
  • added corresponding entries in CHANGELOG_UNRELEASED.md
  • added corresponding documentation in the headers

Reference: How to document

Reminder to reviewers

@affeldt-aist
Copy link
Member

What is really not recommended is to let destruct figure out names itself but indeed we can do without it as shown in the last commit.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants