Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NOMRG ENH: add pyproject.toml to fix wheel building and install from github #218

Closed
wants to merge 9 commits into from

Conversation

mathurinm
Copy link
Owner

@mathurinm mathurinm commented Mar 2, 2022

fixes #122

@codecov-commenter
Copy link

codecov-commenter commented Mar 2, 2022

Codecov Report

Merging #218 (b3da5b2) into main (f7fa260) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #218   +/-   ##
=======================================
  Coverage   85.79%   85.79%           
=======================================
  Files          14       14           
  Lines         929      929           
  Branches      128      128           
=======================================
  Hits          797      797           
  Misses        101      101           
  Partials       31       31           
Flag Coverage Δ
unittests ∅ <ø> (∅)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f7fa260...b3da5b2. Read the comment docs.

@mathurinm mathurinm changed the title NOMRG: Test pyproject ENH: add pytproject.toml to fix wheel building and install from github Mar 2, 2022
@mathurinm mathurinm changed the title ENH: add pytproject.toml to fix wheel building and install from github ENH: add pyproject.toml to fix wheel building and install from github Mar 2, 2022
@mathurinm mathurinm mentioned this pull request Mar 2, 2022
@mathurinm mathurinm requested a review from agramfort March 2, 2022 20:22
@mathurinm mathurinm changed the title ENH: add pyproject.toml to fix wheel building and install from github NOMRG ENH: add pyproject.toml to fix wheel building and install from github Mar 3, 2022
@mathurinm
Copy link
Owner Author

mathurinm commented Mar 3, 2022

In a fresh python 3.8 env pip install git+https://github.com/mathurinm/celer.git@main works but pip install git+https://github.com/mathurinm/celer.git@test_pyproject does not

@Badr-MOUFAD
Copy link
Collaborator

Closing as it is no longer a problem.

P.S Switch to pyproject.toml was made in #284

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

BUG: installing celer with pip from github first fails, then succeeds
4 participants