Skip to content

Commit

Permalink
MINOR: [Go] Correct benchmark units from bits/s to bytes/s (apache#37479
Browse files Browse the repository at this point in the history
)

### Rationale for this change

We're trying to clean up the set of units used in Conbench, and the Go benchmarks stick out as `b/s` (bits per second), but looking at 

https://github.com/apache/arrow/blob/602083be4f9630eda3edaf3ac18a660ccce91468/ci/scripts/go_bench_adapt.py#L86

it looks like they're actually in `B/s` (bytes per second).

### What changes are included in this PR?

Just changing the units submitted to Conbench

### Are these changes tested?

No, but the unit will be validated by the Conbench API

### Are there any user-facing changes?

No

Authored-by: Edward Visel <[email protected]>
Signed-off-by: Antoine Pitrou <[email protected]>
  • Loading branch information
alistaire47 authored Aug 31, 2023
1 parent c99d318 commit 323a92f
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion ci/scripts/go_bench_adapt.py
Original file line number Diff line number Diff line change
Expand Up @@ -95,7 +95,7 @@ def _transform_results(self) -> List[BenchmarkResult]:
batch_id=batch_id,
stats={
"data": [data],
"unit": "b/s",
"unit": "B/s",
"times": [time],
"time_unit": "i/s",
"iterations": benchmark["Runs"],
Expand Down

0 comments on commit 323a92f

Please sign in to comment.