Skip to content

Commit

Permalink
apacheGH-37384: [R] Set _R_CHECK_STOP_ON_INVALID_NUMERIC_VERSION_INPU…
Browse files Browse the repository at this point in the history
…TS_ = TRUE on CI (apache#37385)

### Rationale for this change

Checks fail on CRAN which don't fail on our CI - we should make them fail on our CI instead of just issue a warning

### What changes are included in this PR?

Update settings for R builds so these checks raise error not warning

### Are these changes tested?

Nope 

### Are there any user-facing changes?

No
* Closes: apache#37384

Authored-by: Nic Crane <[email protected]>
Signed-off-by: Nic Crane <[email protected]>
  • Loading branch information
thisisnic authored Aug 25, 2023
1 parent 45c60ee commit c079dac
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 1 deletion.
3 changes: 2 additions & 1 deletion .github/workflows/r.yml
Original file line number Diff line number Diff line change
Expand Up @@ -305,7 +305,8 @@ jobs:
RWINLIB_LOCAL = file.path(Sys.getenv("GITHUB_WORKSPACE"), "r", "windows", "libarrow.zip"),
MAKEFLAGS = paste0("-j", parallel::detectCores()),
ARROW_R_DEV = TRUE,
"_R_CHECK_FORCE_SUGGESTS_" = FALSE
"_R_CHECK_FORCE_SUGGESTS_" = FALSE,
"_R_CHECK_STOP_ON_INVALID_NUMERIC_VERSION_INPUTS_" = TRUE
)
rcmdcheck::rcmdcheck(".",
build_args = '--no-build-vignettes',
Expand Down
2 changes: 2 additions & 0 deletions ci/scripts/r_test.sh
Original file line number Diff line number Diff line change
Expand Up @@ -65,6 +65,8 @@ export _R_CHECK_DONTTEST_EXAMPLES_=TRUE
export _R_CHECK_FORCE_SUGGESTS_=FALSE
export _R_CHECK_LIMIT_CORES_=FALSE
export _R_CHECK_TESTS_NLINES_=0
# This can cause failures on CRAN but needs to be set here so issues an error not a warning
export _R_CHECK_STOP_ON_INVALID_NUMERIC_VERSION_INPUTS_=TRUE

# By default, aws-sdk tries to contact a non-existing local ip host
# to retrieve metadata. Disable this so that S3FileSystem tests run faster.
Expand Down

0 comments on commit c079dac

Please sign in to comment.