Skip to content

Commit

Permalink
1. Set the ArrayStaticConstructor property of ListTraits to
Browse files Browse the repository at this point in the history
   @arrow.array.ListArray.fromMATLAB - not the MatlabConstructor
   property
2. Set the MatlabConstructor property of ListTraits back to missing
  • Loading branch information
sgilmore10 committed Nov 2, 2023
1 parent 3179b77 commit c534255
Show file tree
Hide file tree
Showing 2 changed files with 8 additions and 4 deletions.
6 changes: 4 additions & 2 deletions matlab/src/matlab/+arrow/+type/+traits/ListTraits.m
Original file line number Diff line number Diff line change
Expand Up @@ -19,11 +19,13 @@
ArrayConstructor = @arrow.array.ListArray
ArrayClassName = "arrow.array.ListArray"
ArrayProxyClassName = "arrow.array.proxy.ListArray"
ArrayStaticConstructor = missing
ArrayStaticConstructor = @arrow.array.ListArray.fromMATLAB
TypeConstructor = @arrow.type.ListType
TypeClassName = "arrow.type.ListType"
TypeProxyClassName = "arrow.type.proxy.ListType"
MatlabConstructor = @arrow.array.ListArray.fromMATLAB
% The cell function works differently than other
% "type construction functions" in MATLAB.
MatlabConstructor = missing
MatlabClassName = "cell"
end

Expand Down
6 changes: 4 additions & 2 deletions matlab/test/arrow/type/traits/tListTraits.m
Original file line number Diff line number Diff line change
Expand Up @@ -20,11 +20,13 @@
ArrayConstructor = @arrow.array.ListArray
ArrayClassName = "arrow.array.ListArray"
ArrayProxyClassName = "arrow.array.proxy.ListArray"
ArrayStaticConstructor = missing
ArrayStaticConstructor = @arrow.array.ListArray.fromMATLAB
TypeConstructor = @arrow.type.ListType
TypeClassName = "arrow.type.ListType"
TypeProxyClassName = "arrow.type.proxy.ListType"
MatlabConstructor = @arrow.array.ListArray.fromMATLAB
% The cell function works differently than other
% "type construction functions" in MATLAB.
MatlabConstructor = missing
MatlabClassName = "cell"
end

Expand Down

0 comments on commit c534255

Please sign in to comment.