CachingPageTracer Optimization #172

vidyasilai · 2024-10-28T18:06:16Z

This PR implements a solution to the issue described in #170. It builds upon the existing PageTracer infrastructure to cache outgoing reference information for pages.

tonyastolfi

Here is my initial review.

I'm going to think about finalized_deleted_pages_ based on your comments. I'm not sure it is needed either, but want to give myself some time to ponder.

Thanks for this PR!

src/llfs/api_types.hpp

src/llfs/committable_page_cache_job.cpp

src/llfs/page_tracer.hpp

src/llfs/no_outgoing_refs_cache.cpp

src/llfs/no_outgoing_refs_cache.hpp

src/llfs/page_cache_job.hpp

src/llfs/page_device_entry.hpp

src/llfs/no_outgoing_refs_cache.hpp

src/llfs/no_outgoing_refs_cache.cpp

src/llfs/committable_page_cache_job.hpp

tonyastolfi

Thanks for the offline explanation of the purpose of finalized_deleted_pages_. I like the idea, just think the polarity of the set should be reversed to optimize the common case, as noted in a new comment at the declaration of this data member.

vidyasilai added 3 commits October 25, 2024 16:40

Initial commit, WIP

66420ff

Started adding tests

aba51f2

Finished tests

db7070a

vidyasilai self-assigned this Oct 28, 2024

vidyasilai requested review from tonyastolfi, gabrielbornstein and bhaskarbora2 October 28, 2024 18:12

tonyastolfi reviewed Oct 28, 2024

View reviewed changes

Addressed first set of review feedback

b1155e9