Agrego timeout para la conexión #18
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MegaRedHand
reviewed
Sep 27, 2022
No manda ACKs para paquetes ya recibidos previamente, salvo por el último recibido.
- corrijo timers en Connection (ahora usa monotonic) - Sender ignora ACKs duplicados luego de reenviar paquetes (por un tamaño de ventana) - corrijo timeout en el cliente (estaba duplicando la recepción de paquetes) - cambio el formato de algunos logs
para mayor exactitud en el tamaño del archivo
Se estaba moviendo más de lo necesario cuando llegaba al final del archivo, y sacaba del buffer paquetes no confirmados. Entonces al reenviar paquetes, enviaba paquetes de menos.
- agrego constante con el tamaño del header - faltaba un break en protocol
* Cambiar funcionamiento de la ventana de gbn * Corrijo error en el inicio de la conexión El cliente repetía el número de secuencia del servidor, por lo que si se perdía el paquete 1, se quedaba en el loop * Unifico partes de upload y download * Aplico formato * Agrego chequeo finalización de conexión al cliente Co-authored-by: Tomas Gruner <[email protected]>
MegaRedHand
approved these changes
Sep 29, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.