This repository has been archived by the owner on Nov 19, 2019. It is now read-only.
Not possible to get the directory path for self-contained executable #56
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Xeinaemm
commented
Nov 3, 2019
Comment on lines
+62
to
+63
| ToolPathResolver.NuGetAssetsConfigFile = NukeBuild.BuildProjectDirectory / "obj" / "project.assets.json"; | ||
| ToolPathResolver.NuGetPackagesConfigFile = build.NuGetPackagesConfigFile; |
There was a problem hiding this comment.
Previously we tried to assign null to ToolPathResolver.NuGetAssetsConfigFile without checking NukeBuild.BuildProjectDirectory it's not null.
Xeinaemm
commented
Nov 3, 2019
|
|
||
| if (entryAssembly == null | ||
| || entryAssembly.GetTypes().All(x => !x.IsSubclassOf(typeof(NukeBuild))) | ||
| || !EnvironmentInfo.ValidDirectoryPath(entryAssembly.Location)) |
There was a problem hiding this comment.
The self-contained app doesn't have a build project so we will assign null because should be standalone in invoke.
Xeinaemm
commented
Nov 3, 2019
Comment on lines
+27
to
+29
| get => ValidDirectoryPath(Directory.GetCurrentDirectory()) | ||
| ? Directory.GetCurrentDirectory() | ||
| : Path.GetDirectoryName(Process.GetCurrentProcess().MainModule?.FileName); |
There was a problem hiding this comment.
If a standard approach with valid path(not points to temp path) returns as previous otherwise withdraws path from the process.
matkoch
force-pushed
the
develop
branch
5 times, most recently
from
5f5fb10 to
6d93e61
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes nuke-build/nuke#330