Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: PrivacyInfo.xcprivacy is not linked when importing by cocoapods #453

Conversation

krazzbeluh
Copy link
Contributor

As mentionned by qasimmajeed in issue #447 (SDKs that require a privacy manifest and signature), the privacy manifest is not linked in resources when importing MatomoTracker via cocoapods.

The goal of this PR is to link the file privacy manifest in the resources bundle when importing the lib via cocoapods.

Testing :

  1. import MatomoTracker using my branch (pod 'MatomoTracker', git: 'https://github.com/krazzbeluh/matomo-sdk-ios.git', :branch => 'fix/privacy-manifest-is-not-linked-with-cocoapods')
  2. pod install
  3. The PrivacyInfo.xcprivacy file should be visible in Pods/Pods/MatomoTracker/Resources

Copy link
Member

@brototyp brototyp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@brototyp brototyp merged commit 2995fb7 into matomo-org:develop Jun 10, 2024
6 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants