Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hide the GA option if the user doesn't have superuser access #486

Merged
merged 2 commits into from
Jan 12, 2024

Conversation

snake14
Copy link
Contributor

@snake14 snake14 commented Jan 12, 2024

Description:

This hides the GA option from the no data screen if the user doesn't have superuser access.
Fixes: L3-638

Review

Copy link
Contributor

@AltamashShaikh AltamashShaikh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍

@snake14
Copy link
Contributor Author

snake14 commented Jan 12, 2024

The failing UI test cases are due to the core navigation bar change. We're hoping for a core fix soon so that we don't have to update the screenshots multiple times. I'm going ahead and merging.

@snake14 snake14 merged commit dec8532 into 5.x-dev Jan 12, 2024
4 of 5 checks passed
@snake14 snake14 deleted the l3-638-hide-ga-option-non-super-users branch January 12, 2024 02:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants