-
-
Notifications
You must be signed in to change notification settings - Fork 674
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Slightly refactor latestEventsUpdater
#3272
Open
S7evinK
wants to merge
21
commits into
main
Choose a base branch
from
s7evink/latest-event-updater
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
S7evinK
added
the
T-Task
Refactoring, removal, replacement, enabling or disabling functionality, other engineering tasks.
label
Nov 23, 2023
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3272 +/- ##
==========================================
- Coverage 67.54% 67.53% -0.01%
==========================================
Files 521 521
Lines 47381 47384 +3
==========================================
+ Hits 32002 32003 +1
- Misses 11394 11397 +3
+ Partials 3985 3984 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
S7evinK
commented
Nov 23, 2023
…test-event-updater
…test-event-updater
…test-event-updater
…test-event-updater
This reverts commit 925843d.
…test-event-updater
…test-event-updater
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
T-Task
Refactoring, removal, replacement, enabling or disabling functionality, other engineering tasks.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In an attempt to make testing the
latestEventsUpdater
easier, some moving around of variables and method calls.