-
-
Notifications
You must be signed in to change notification settings - Fork 674
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Url preview endpoint #3437
Open
adnull
wants to merge
15
commits into
matrix-org:main
Choose a base branch
from
adnull:url-preview
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Url preview endpoint #3437
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Aleksandr Dubovikov <[email protected]>
Signed-off-by: Aleksandr Dubovikov <[email protected]>
Signed-off-by: Aleksandr Dubovikov <[email protected]>
Signed-off-by: Aleksandr Dubovikov <[email protected]>
Signed-off-by: Aleksandr Dubovikov <[email protected]>
Signed-off-by: Aleksandr Dubovikov <[email protected]>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3437 +/- ##
==========================================
- Coverage 67.74% 67.74% -0.01%
==========================================
Files 518 519 +1
Lines 47457 47881 +424
==========================================
+ Hits 32150 32437 +287
- Misses 11311 11393 +82
- Partials 3996 4051 +55
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Signed-off-by: Aleksandr Dubovikov <[email protected]>
Signed-off-by: Aleksandr Dubovikov <[email protected]>
Signed-off-by: Aleksandr Dubovikov <[email protected]>
Signed-off-by: Aleksandr Dubovikov <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces the missing URL Preview functionality ( Issue #1303 )
According to the specification that endpoint requests require authentication and are rate limited. There are both endpoints (v1 and v3) as some clients still use deprecated endpoints for url preview requests.
Key features:
Missing:
I'd like somebody to take a look at the code.
Signed-off-by:
Aleksandr Dubovikov <[email protected]>