Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove the libbase58 pod dependency #1829

Closed
wants to merge 6 commits into from
Closed

Conversation

ARiezn
Copy link

@ARiezn ARiezn commented Oct 26, 2023

Summary

Completely remove libbase58 dependency and replace it with ObjC implementation to manage base58 for keys backup.

Details

See issue #1828 for details

Pull Request Checklist

@ARiezn
Copy link
Author

ARiezn commented Oct 26, 2023

Signed-off-by: Artem Rieznikov [email protected]

@pixlwave
Copy link
Member

Hey @ARiezn, thanks for this PR. Unfortunately we won't be able to accept it at this time. Until CocoaPods/CocoaPods#11839 is fixed, we're developing this pod against Xcode 14.2.

Side note: as we're starting to transition to a Rust-backed world with https://github.com/matrix-org/matrix-rust-components-swift/ large changes to this library are unlikely to be accepted.

@pixlwave pixlwave closed this Oct 26, 2023
@ARiezn
Copy link
Author

ARiezn commented Oct 31, 2023

@pixlwave , thank you for your attention to my PR. I want to highlight that the change proposed in this PR does not actually require to switch from using Xcode 14.2 for building. It will not break compatibility with Xcode 14.2. So continuation of using the same version of XCode should not be a problem at all. It will only make it possible to build using Xcode 14.3 or above (since the libbase58 dependency is removed). Is it possible to reconsider the decision to close the PR? Let me know if there are some other requirements or necessary changes that I may take into account.

@pixlwave
Copy link
Member

pixlwave commented Nov 2, 2023

Hi, sorry I'm afraid not at this time @ARiezn.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants