Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Restore createKeyWithKeyId #1885

Draft
wants to merge 1 commit into
base: develop
Choose a base branch
from
Draft

Restore createKeyWithKeyId #1885

wants to merge 1 commit into from

Conversation

Velin92
Copy link
Member

@Velin92 Velin92 commented Oct 23, 2024

No description provided.

Velin92
Velin92 commented Oct 23, 2024
View reviewed changes
MatrixSDK/Crypto/SecretStorage/MXSecretStorage.m
}
else
{
OLMPkDecryption *decryption = [OLMPkDecryption new];
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This uses OLMKit

Copy link
Member

@BillCarsonFr BillCarsonFr Oct 25, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This uses OLMKit

I think it's just generating 32 random bytes, you can replace with SecRandomCopyBytes

@Velin92 Velin92 changed the title Restore createKeyWithId Restore createKeyWithKeyId Oct 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BillCarsonFr BillCarsonFr BillCarsonFr left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Velin92 @BillCarsonFr