Remove deprecated calls in webrtc/call.ts
#4562
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
florianduros
force-pushed
the
florianduros/rip-out-legacy-crypto/call
branch
from
add17fb to
601c4eb
Compare
florianduros
force-pushed
the
florianduros/rip-out-legacy-crypto/call
branch
from
601c4eb to
a45de2f
Compare
robintown
reviewed
Dec 5, 2024
robintown
approved these changes
Dec 6, 2024
|
@florianduros looks like maybe this has got stuck? |
|
@richvdh No, this PR can be merged when will drop the support of the legacy crypto. If we do it sooner, we will break the legacy call when using the legacy crypto. |
florianduros
changed the base branch from
develop
to
florianduros/rip-out-legacy-crypto/remove-legacy-crypto
florianduros
merged commit d12fcc4
into
florianduros/rip-out-legacy-crypto/remove-legacy-crypto
40 of 42 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
public/exportedsymbols have accurate TSDoc documentation.Require #4620
webrtc/call.tsuses deprecated and unsupported methods by the rust cryptography. I suppose it's somewhat broken since the usage of the rust cryptography.I removed theses calls for element-hq/element-web#26922
We wait for the js-sdk to drop the support of the legacy crypto (element-hq/element-web#26922) to merge it in order to keep the feature when the legacy crypto is used.