Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ffi: bump uniffi to latest to generate open swift classes #3174

Merged
merged 1 commit into from
Feb 28, 2024

Conversation

stefanceriu
Copy link
Member

This will pull in mozilla/uniffi-rs#1975 and hopefuly not cause any breaking changes.

@stefanceriu stefanceriu requested a review from a team as a code owner February 28, 2024 12:21
@stefanceriu stefanceriu requested review from poljar and removed request for a team February 28, 2024 12:21
Copy link
Contributor

@poljar poljar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine, does it also work?

@stefanceriu
Copy link
Member Author

Let's see what the CI has to say first, then I'll test it locally.

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 83.85%. Comparing base (0521d23) to head (509a0e1).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3174   +/-   ##
=======================================
  Coverage   83.85%   83.85%           
=======================================
  Files         232      232           
  Lines       23938    23938           
=======================================
  Hits        20073    20073           
  Misses       3865     3865           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@stefanceriu
Copy link
Member Author

All good, I'll go see what happens when I try to use it for real

@stefanceriu
Copy link
Member Author

Works great, 🐑 it! 🎉

@poljar poljar merged commit 8392ef0 into main Feb 28, 2024
32 checks passed
@poljar poljar deleted the stefan/uniffi_bump branch February 28, 2024 17:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants