Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MSC3767: Time based notification filtering #3767
base: main
Are you sure you want to change the base?
MSC3767: Time based notification filtering #3767
Changes from 10 commits
285f315
1348ad1
ca714a4
f5ce11f
a4ff31a
40f6faf
1dff420
6a4aca3
dd00ad4
80d46d2
1131e67
b30e3ba
92560a7
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This RFC is linked as supposedly solving the "temporarily mute channel" feature request. Unless for business users maybe, most of the time people want to simply ad-hoc temporarily mute channels for X time units, and not configure some complex time-of-day based rules. How does this RFC help implementing the former?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it doesn't. That would probably require a separate MSC. The purpose here was to allow setting up pre-defined DND schedules.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Isn't that an overhead that can be avoided?
Isn't it better to omit the time zone and always handle the time zone in the client? Then an unintentional security issue would not occur.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not all platforms are able to filter notifications locally. On iOS, for instance, you need to explicitly request a special entitlement from Apple which not all iOS clients might be willing or able to do.
Also, in many cases the security issue occurs anyway regardless of whether you apply the time zone on the client or the server. As soon as you set it up to reflect your work hours, for instance, it'll be possible to infer your approximate time zone.