Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MSC4123: Allow knock -> join transition #4123

Closed
wants to merge 2 commits into from
Closed

MSC4123: Allow knock -> join transition #4123

wants to merge 2 commits into from

Conversation

Kladki
Copy link
Contributor

@Kladki Kladki commented Apr 6, 2024

@tulir tulir added requires-room-version An idea which will require a bump in room version proposal A matrix spec change proposal unassigned-room-version Remove this label when things get versioned. kind:maintenance MSC which clarifies/updates existing spec needs-implementation This MSC does not have a qualifying implementation for the SCT to review. The MSC cannot enter FCP. labels Apr 6, 2024
tulir
tulir reviewed Apr 7, 2024
View reviewed changes
proposals/4123-knock-join-transition.md
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@zecakeh pointed out that these transitions are already allowed according to the auth rules

As long as the user isn't banned, rule 4.3.6 allows joining if join_rule is public regardless of current membership, and rule 4.3.5.3 does the same for restricted rooms if the authorised via user key is valid.

image

So it seems like the table and the graph in the client-server API are just wrong and can be fixed without an MSC

Copy link
Member

@tulir tulir Apr 7, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

And apparently ¼ of the spec PR already exists: matrix-org/matrix-spec#1709 (missing parts: knock -> join for public rooms in the graph, and updating the table for both cases)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i have to ask if this has been confirmed to be correct behavior so we arent walking straight into another Knock Invite mess. Like im not taking a stance on if this needs a MSC or not just asking that we make sure we arent walking into another mess of that magnitude.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ruma (and hence Conduit) already allowed the knock -> join transition, not sure about Synapse and Dendrite.

@Kladki
Copy link
Contributor Author

Kladki commented Apr 7, 2024

As per #4123 (comment)

@Kladki Kladki closed this Apr 7, 2024
@Kladki
Copy link
Contributor Author

Kladki commented Apr 7, 2024 via email

@turt2live turt2live added the obsolete A proposal which has been overtaken by other proposals label Apr 7, 2024
@Kladki Kladki deleted the knock-join-transition branch May 18, 2024 16:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tulir tulir tulir left review comments

@FSG-Cat FSG-Cat FSG-Cat left review comments

Assignees
No one assigned
Labels
kind:maintenance MSC which clarifies/updates existing spec needs-implementation This MSC does not have a qualifying implementation for the SCT to review. The MSC cannot enter FCP. obsolete A proposal which has been overtaken by other proposals proposal A matrix spec change proposal requires-room-version An idea which will require a bump in room version unassigned-room-version Remove this label when things get versioned.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Kladki @tulir @FSG-Cat @turt2live