MSC4141: Time based notification filtering #4141
Conversation
Signed-off-by: Kerry Archibald <[email protected]>
Signed-off-by: Kerry Archibald <[email protected]>
Signed-off-by: Kerry Archibald <[email protected]>
Signed-off-by: Kerry Archibald <[email protected]>
Signed-off-by: Kerry Archibald <[email protected]>
Signed-off-by: Kerry Archibald <[email protected]>
Signed-off-by: Kerry Archibald <[email protected]>
Signed-off-by: Kerry Archibald <[email protected]>
Signed-off-by: Kerry Archibald <[email protected]>
Signed-off-by: Kerry Archibald <[email protected]>
Signed-off-by: Kerry Archibald <[email protected]>
Signed-off-by: Kerry Archibald <[email protected]>
Signed-off-by: Kerry Archibald <[email protected]>
hanadi92
changed the title
turt2live
added
push
proposal
There was a problem hiding this comment.
Implementation requirements:
- Client exposing UI for these options
- Server supporting these options
- Users demonstrating that this feature works for them (lack of bug reports, significant complaints, etc)
There was a problem hiding this comment.
server implementation on Synapse is already open and ready for review here element-hq/synapse#16858
| ##### `dont_notify` and Do Not Disturb behaviour | ||
| `dont_notify` will stop badges from being | ||
| updated in the client during 'do not disturb' hours, so the user will not be | ||
| able to locate messages that were silenced when they are back online. | ||
| To silence push notifications but allow discovery of missed messages in app, `notify_in_app` as proposed in | ||
| [MSC3768](https://github.com/matrix-org/matrix-spec-proposals/pull/3768) should | ||
| be used. |
There was a problem hiding this comment.
I rely on seeing the red dots on chats that I have been mentioned in overnight in order to figure out what I need to address every morning, so I think that this is a significant enough UX problem to require blocking this MSC on MSC3768.
| be used. | ||
|
|
||
| ## Potential issues | ||
| - If a user changes timezone their push rules will not automatically update. |
There was a problem hiding this comment.
As someone who travels often, I think that this is a major concern. At the very least, we need to add a recommendation that clients either automatically change timezone when they enter a new timezone, or prompt the user to manually change it.
But, as mentioned I think that this functionality should be implemented by the operating system the client is running on, as it has full timezone and DND state information.
| #### System | ||
| Some systems (e.g. iOS) have their own DND / focus mode but this is only an option if all of your devices are within | ||
| that vendor ecosystem (here Apple) and doesn't help when you have e.g. an iPad and an Android phone. This also needs to | ||
| be configured per device. |
There was a problem hiding this comment.
Personally, I think that this entire functionality should be handled by the operating system of the client. Fundamentally, the client is where the necessary information (namely DND status) resides.
I can think of many edge cases that can cause a server-driven approach as suggested in this MSC to fail:
- Travel: as already mentioned, users will be confused when the notification rules are off by whatever timezone offset they've traveled to.
- Overridden DND off: if you are up late (maybe pulling an all-nighter to study for a test) and want to have your notifications on all night (maybe classmates texting study tips), you would want to be able to turn of the DND and have notifications show up.
Clients should just spit notifications out and allow the operating system to hide/show them depending on whatever rules are configured on the OS level. This will ensure that we can take advantage of whatever notification management features are provided by operating systems both now and in the future.
Obviously, it is annoying to have to configure it on multiple ecosystems, but I think this MSC actually makes it worse as you would have to configure your Matrix client DND settings in addition to your OS DND settings.
| #### System | ||
| Some systems (e.g. iOS) have their own DND / focus mode but this is only an option if all of your devices are within | ||
| that vendor ecosystem (here Apple) and doesn't help when you have e.g. an iPad and an Android phone. This also needs to | ||
| be configured per device. |
There was a problem hiding this comment.
It appears that per-device rules are going away: matrix-org/matrix-spec#1842
| ## Security considerations | ||
| - Stores user's timezone on the server. DND periods saved to the server without timezone information would reveal | ||
| information about a user's approximate timezone anyway. Users who do not wish to store their timezone can set DND | ||
| periods in UTC (this option should be available in clients implementing time based notification filtering). |
There was a problem hiding this comment.
I think that forcing all times to be expressed in UTC time should be listed as an alternative. Since users will not be interacting directly with the state event, I think clients should always translate the user's setting into UTC time.
| - While this MSC is not considered stable `time_and_day` should be referred to as `org.matrix.msc4141.time_and_day` | ||
|
|
||
| ## Dependencies | ||
| None. |
There was a problem hiding this comment.
As mentioned in another comment, I think MSC3768 should be a dependency.
Rendered
Took on this old MSC #3767 on time based notification filtering (do not disturb) and only added a detailed spec on the day-of-week numbering schema.
p.s. I kept the commits from the original author and just added mine on top.
Signed-off-by: Hanadi @hanadi92