Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MSC4213: Remove server_name parameter from join and knock endpoints #4213

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

Johennes
Copy link
Contributor

@Johennes Johennes commented Oct 9, 2024

Rendered


In line with matrix-org/matrix-spec#1700, the following disclosure applies:

I am a Systems Architect at gematik, Software Engineer at Unomed, Matrix community member and former Element employee. This proposal was written and published with my community member hat on.


FCP tickyboxes

@Johennes Johennes force-pushed the johannes/remove-server-name branch 2 times, most recently from b894e89 to a083ae4 Compare October 9, 2024 10:12
@Johennes Johennes changed the title MSCXXXX: Remove server_name parameter MSC4213: Remove server_name parameter Oct 9, 2024
@Johennes Johennes force-pushed the johannes/remove-server-name branch from a083ae4 to f011a86 Compare October 9, 2024 10:14
@Johennes Johennes marked this pull request as ready for review October 9, 2024 10:15
@turt2live turt2live added proposal A matrix spec change proposal client-server Client-Server API kind:maintenance MSC which clarifies/updates existing spec needs-implementation This MSC does not have a qualifying implementation for the SCT to review. The MSC cannot enter FCP. labels Oct 9, 2024
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Implementation requirements:

I'm tempted to mirror #4127 (comment) and say "none", but am second-guessing that MSC's requirements too. It might be beneficial to have evidence that developers are picking up the newer approaches before suggesting removal from the spec.

Thoughts very welcome.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It might not count because they were all created by me but there are five implementations linked in the proposal's body, four of which have already landed.

@turt2live
Copy link
Member

Using the FCP mechanism to encourage comment/explicit blockers:

@mscbot fcp merge

@mscbot
Copy link
Collaborator

mscbot commented Nov 18, 2024

Team member @mscbot has proposed to merge this. The next step is review by the rest of the tagged people:

Concerns:

  • implementation-needs-checking label

Once at least 75% of reviewers approve (and there are no outstanding concerns), this will enter its final comment period. If you spot a major issue that hasn't been raised at any point in this process, please speak up!

See this document for information about what commands tagged team members can give me.

@mscbot mscbot added proposed-final-comment-period Currently awaiting signoff of a majority of team members in order to enter the final comment period. disposition-merge labels Nov 18, 2024
@turt2live turt2live added implementation-needs-checking The MSC has an implementation, but the SCT has not yet checked it. and removed needs-implementation This MSC does not have a qualifying implementation for the SCT to review. The MSC cannot enter FCP. labels Nov 18, 2024
@turt2live
Copy link
Member

@mscbot concern implementation-needs-checking label

@mscbot mscbot added the unresolved-concerns This proposal has at least one outstanding concern label Nov 18, 2024
dbkr

This comment was marked as outdated.


- synapse: https://github.com/element-hq/synapse/pull/17650
- dendrite: https://github.com/matrix-org/dendrite/pull/3438
- matrix-js-sdk: https://github.com/matrix-org/matrix-js-sdk/pull/4381
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's possible I'm confused but matrix-org/matrix-js-sdk#4381 removes the unstable prefix from the 'via' param. This MSC is about removing the old server_name param, which is a different thing.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The linked implementations are for MSC4156 which added the via param. They're listed to show that the old server_name parameter is safe to remove

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, exactly. I think the server_name parameter will probably stay in implementations for quite a while unless they consciously choose to only support Matrix >= 1.12. But we don't need it in the spec anymore.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh right, I see - I guess I was confused by your comment. In that case I guess I can vouch for the js-sdk impl, in that it now sends the via param.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The server impl looks plausible too. I think we could remove the implementation-needs-checking label.?

@richvdh richvdh changed the title MSC4213: Remove server_name parameter MSC4213: Remove server_name parameter from join and knock endpoints Nov 19, 2024
@turt2live
Copy link
Member

@mscbot resolve implementation-needs-checking label

@mscbot mscbot removed the unresolved-concerns This proposal has at least one outstanding concern label Nov 19, 2024
@turt2live turt2live added unresolved-concerns This proposal has at least one outstanding concern and removed implementation-needs-checking The MSC has an implementation, but the SCT has not yet checked it. unresolved-concerns This proposal has at least one outstanding concern labels Nov 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
client-server Client-Server API disposition-merge hacktoberfest-accepted kind:maintenance MSC which clarifies/updates existing spec proposal A matrix spec change proposal proposed-final-comment-period Currently awaiting signoff of a majority of team members in order to enter the final comment period.
Projects
Status: Ready for FCP ticks
Development

Successfully merging this pull request may close these issues.

8 participants