Use auto table-layout on desktop #1601
Conversation
| * Thus, we override the "display" property here. This may no longer be necessary once | ||
| * Docsy updates to Bootstrap v5+: https://github.com/google/docsy/issues/470. | ||
| * For more details, see | ||
| * https://github.com/matrix-org/matrix-spec/pull/1295/files#r1010759688 */ |
There was a problem hiding this comment.
I wonder if we should update our fork of docsy now that google/docsy#470 is closed...
Anyway, I guess that is a separate problem.
not-my-profile
force-pushed
the
table-layout-auto
branch
from
1e19200
to
0d201e8
Compare
|
Just signed-off the commit. I'd be happy to add a changelog entry but none of the allowed changelog entry types fits this PR (new, feature, clarification, breaking, deprecation). I'd classify this as "style" but I'm assuming |
|
Thanks! You could make it a |
|
CONTRIBUTING.rst defines
That really sounds like a change to the text of the spec ... so I don't really want to classify it as "clarification" since I'd consider that as misleading. |
|
I mean you're right, and #1369 mentions the fact that it's not a great match. But it's what we use for now. Compare https://spec.matrix.org/v1.7/changelog/#internal-changestooling for where we've done this in the past. None of those are really changes to the spec. |
Signed-off-by: Martin Fischer <[email protected]>
not-my-profile
force-pushed
the
table-layout-auto
branch
from
0d201e8
to
011a511
Compare
|
Fair enough ... added the newsfragment. |
| @@ -0,0 +1 @@ | |||
| Improve the layout of tables on desktop. | |||
There was a problem hiding this comment.
| Improve the layout of tables on desktop. | |
| Improve the layout of tables on desktop displays. Contributed by @not-my-profile. |
There was a problem hiding this comment.
I don't really like my work being attributed to my GitHub username :/
There was a problem hiding this comment.
would you prefer an alternative attribution?
There was a problem hiding this comment.
Yeah: Martin Fischer.
Per request at #1601 (comment)
On desktop the tables in the specification currently have quite awkward column widths, making them harder to read.
While the fixed table-layout does have an advantage on mobile since it avoids unnecessary horizontal scrolling in the tables, we can just use it on narrow browser widths via a media query, while still using the more readable auto layout on desktop.
Preview: https://pr1601--matrix-spec-previews.netlify.app