-
-
Notifications
You must be signed in to change notification settings - Fork 96
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix schema of m.receipt
EDU
#1636
Conversation
It was missing a nesting level for the user ID -> user read receipt map. Signed-off-by: Kévin Commaille <[email protected]>
Signed-off-by: Kévin Commaille <[email protected]>
A few links:
|
additionalProperties: | ||
type: object |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we should document what the key of the object is (the user id), much as we do for the content
object above it:
matrix-spec/data/api/server-server/definitions/event-schemas/m.receipt.yaml
Lines 34 to 35 in 9c995df
Receipts for a particular room. The string key is the room ID for | |
which the receipts under it belong. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I documented it
Signed-off-by: Kévin Commaille <[email protected]>
Signed-off-by: Kévin Commaille <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks!
It was missing a nesting level for the user ID -> user read receipt map.
Preview: https://pr1636--matrix-spec-previews.netlify.app