Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add spec for shared-history room keys (MSC3061) #1655

Closed
wants to merge 4 commits into from

Conversation

uhoreg
Copy link
Member

@uhoreg uhoreg commented Oct 4, 2023

@uhoreg uhoreg requested a review from a team as a code owner October 4, 2023 00:43
Copy link
Contributor

@poljar poljar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we push this to the spec, considering the problems which were subsequently discovered with this MSC3061?

Copy link
Member

@richvdh richvdh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pending a decision about wtf we are doing here

@richvdh
Copy link
Member

richvdh commented Feb 26, 2024

Given this completed FCP, it belongs in the spec. If we want to rip it out the spec again, that will require a new MSC.

@richvdh richvdh requested a review from a team February 26, 2024 14:45
@richvdh
Copy link
Member

richvdh commented Feb 27, 2024

Apparently there are security concerns, specifically around sharing keys for past messages. We'll disclose more details in a few weeks, and then we can decide how best to proceed here.

Co-authored-by: Johannes Marbach <[email protected]>
Copy link
Member

@turt2live turt2live left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clearing team review request while awaiting security impact

@murlock1000
Copy link

murlock1000 commented Jul 8, 2024

With the recent migration of element clients to the rust SDK this introduced a regression of the spec (Breaks historical room key sharing feature). Any updates on this @turt2live ?

@dkasak
Copy link
Member

dkasak commented Oct 15, 2024

The reason this was blocked was disclosed in https://matrix.org/blog/2024/10/security-disclosure-matrix-js-sdk-and-matrix-react-sdk/ and the associated advisories. The plan forward is outlined in this section.

Copy link
Member

@turt2live turt2live left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Formalizing "proposed spec changes" at https://matrix.org/blog/2024/10/security-disclosure-matrix-js-sdk-and-matrix-react-sdk/#proposed-specification-changes as requiring action. That future MSC will have impact on this spec PR's text.

@richvdh
Copy link
Member

richvdh commented Oct 29, 2024

MSC3061 has been un-merged, so we're going to abandon this for now.

@richvdh richvdh closed this Oct 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants