server-server-api: Fix grammar #1665
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MTRNord
reviewed
Oct 20, 2023
content/server-server-api.md
Outdated
| @@ -187,7 +187,7 @@ to send. The process overall is as follows: | |||
| for `<hostname>`. | |||
|
|
|||
| 6. If the `/.well-known` request returned an error response, and the | |||
| SRV record was not found, an IP address is resolved using CNAME, AAAA and A | |||
| SRV records were not found, an IP address is resolved using CNAME, AAAA and A | |||
There was a problem hiding this comment.
Isn't matrix set up in a way where there is only one SRV record at any given time? (Though on a quick search I didn't see anything not allowing multiple)
There was a problem hiding this comment.
Standard SRV resolution allows for multiple records, and Matrix never forbade it. But also, steps 4 and 5 refer to different SRV records (_matrix-fed._tcp.<hostname> and _matrix._tcp.<hostname>), so it really should be plural.
On the other hand "the SRV records were not found" sounds like SRV records exist but could not be found for whatever reason. So maybe something like "... and no SRV records are present ...", or "... and no SRV records are found ..." might be better?
uhoreg
reviewed
Oct 25, 2023
17 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Preview: https://pr1665--matrix-spec-previews.netlify.app