-
-
Notifications
You must be signed in to change notification settings - Fork 96
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make clearer in the example that the fallback prefix sequence should be repeated for each line #1690
Conversation
I'm sorry you found it a chore |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for your contribution. Please take a look at the contributing guide, particularly with respect to changelog entries and sign-off.
Thank you for the answer,
I will read the document and adjust the PR accordingly.
…--
Konubinix
GPG Key : 7439106A
Fingerprint: 5993 BE7A DA65 E2D9 06CE 5C36 75D2 3CED 7439 106A
|
IIUC, the only thing I needed to do in that particular case was to sign off my So, I did it :-) Please let me know if there is something I missed. |
I understand that updating the changelog is done only when the API changes. |
Yeah the wording is unclear; apologies. (#1697 should improve it.) Please could you create |
…should be repeated for each line Signed-off-by: Samuel Loury <[email protected]>
Done :-)
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for the contribution! Sorry the review took a while.
I needed to read the spec twice to make sure it was the case.
Also, I encountered an implementation of matrix that added the sequence only for the first line.
I believe that making the first example of the chapter show several lines will make less likely such mistakes in the future.
Preview: https://pr1690--matrix-spec-previews.netlify.app