-
-
Notifications
You must be signed in to change notification settings - Fork 96
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add server support discovery endpoint #1733
Conversation
As per MSC1929. Signed-off-by: Kévin Commaille <[email protected]>
Signed-off-by: Kévin Commaille <[email protected]>
Signed-off-by: Kévin Commaille <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
generally this looks good to me - I have a bunch of minor editorial comments.
Thank you!
contacts: | ||
type: array | ||
description: |- | ||
Ways to contact the server administrator. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should define "administrator" somewhere here. I believe the MSC had some notion of what the admin's contact could be used for - can we incorporate that into the schema somewhere?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't see anything on the MSC about why the admins would be contacted, other than the description of the role
property.
Co-authored-by: Travis Ralston <[email protected]>
Signed-off-by: Kévin Commaille <[email protected]>
Signed-off-by: Kévin Commaille <[email protected]>
Signed-off-by: Kévin Commaille <[email protected]>
Signed-off-by: Kévin Commaille <[email protected]>
@@ -363,6 +363,8 @@ specify parameter values. The flow for this method is as follows: | |||
|
|||
{{% http-api spec="client-server" api="versions" %}} | |||
|
|||
{{% http-api spec="client-server" api="support" %}} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not convinced this belongs under "Server discovery". I'd be inclined to put it in a new "Module", but I'm open to other suggestions
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Rationale behind the suggestion to put it here is you're discovering information about the server without necessarily needing to speak the rest of Matrix. Both authenticated and unauthenticated clients can use this, and it's "before" the homeserver APIs really start to do anything.
Arguably though, we should rename or introduce a section for .well-known
stuff. I think this is best left to a future PR at this stage.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! Apologies for this taking so long to review.
If we do want to move it to another section/module, that can be done with a follow-up PR imo.
It's a bit of an anomaly that https://spec.matrix.org/unstable/client-server-api/#well-known-uri now talks about "Servers hosting the |
As per MSC1929.
Fixes #58.
Preview: https://pr1733--matrix-spec-previews.netlify.app