Remove CSS workaround for scroll-anchoring #1976
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Docsy does not set the `height` anymore, but the `min-height`, which doesn't seem to affect scroll-anchoring. See google/docsy@f22a70e Signed-off-by: Kévin Commaille <[email protected]>
Signed-off-by: Kévin Commaille <[email protected]>
|
... and matrix-org/docsy#5 updates our fork of docsy |
|
The update is not needed, the change was first included in docsy 0.7.0, which predates our current version which is 0.8.0. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Docsy does not set the
heightanymore, but themin-height, which doesn't seem to affect scroll-anchoring. See google/docsy@f22a70ePull Request Checklist
Preview: https://pr1976--matrix-spec-previews.netlify.app