Remove unused release_date from Hugo config
#2042
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It seems unnecessary because it is not used anywhere. Signed-off-by: Kévin Commaille <[email protected]>
The version is updated manually during the release (see /meta/releasing.md), not by CI. Signed-off-by: Kévin Commaille <[email protected]>
Signed-off-by: Kévin Commaille <[email protected]>
anoadragon453
approved these changes
Dec 23, 2024
There was a problem hiding this comment.
This looks good on the surface, but I'd like @turt2live to double-check as he's more familiar with the release process.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It seems unnecessary because it is not used anywhere. Also the date format used in the changelog would change in #2033 so it's unclear if the formats should still match if we keep this.
The second commit removes an erroneous sentence since we are in the area. The version is actually updated manually during the release (as can be seen in
/meta/releasing.md), not by CI.Pull Request Checklist
Preview: https://pr2042--matrix-spec-previews.netlify.app