Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MSC4133: Update profile endpoints to support extended fields #2071

Open
wants to merge 33 commits into
base: main
Choose a base branch
from

Conversation

tcpipuk
Copy link

@tcpipuk tcpipuk commented Feb 14, 2025

Signed-off-by: Tom Foster [email protected]

Pull Request Checklist

Preview: https://pr2071--matrix-spec-previews.netlify.app

@tcpipuk tcpipuk marked this pull request as ready for review February 14, 2025 10:00
@tcpipuk tcpipuk requested a review from a team as a code owner February 14, 2025 10:00
@Half-Shot
Copy link
Contributor

Could you link to matrix-org/matrix-spec-proposals#4133 in the body for easy referencing?

Copy link
Contributor

@Half-Shot Half-Shot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some thoughts I had when reading though. I think largely I'm asking for a section to define the common profile keys, which may expand later when more keys make it into the spec.

But this is a great start, thanks for kicking off.

@clokep clokep requested a review from a team February 17, 2025 22:02
@zecakeh
Copy link
Contributor

zecakeh commented Feb 22, 2025

I think that this also needs at least a small sentence in the "Events on Change of Profile Information" section that other fields are not propagated through m.room.member events (and m.presence?).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants