Persist since token periodically #209
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
there are toDevice events in the response
kegsay
reviewed
Jul 18, 2023
There was a problem hiding this comment.
LGTM, please add a test which mocks up the receiver and asserts that UpdateDeviceSince is:
- called immediately the first time with the correct
sincevalue. - is not called for random events.
- is called for to-device events.
- is called after 1 minute (you'll need to mock this e.g
var timeSince = func(t time.Time) time.Durationand then the test replacestimeSincewith something that returns a high duration.
kegsay
reviewed
Jul 19, 2023
| pid := PollerID{UserID: "@alice:localhost", DeviceID: "FOOBAR"} | ||
|
|
||
| syncResponses := make(chan *SyncResponse, 1) | ||
| accumulator, client := newMocks(func(authHeader, since string) (*SyncResponse, int, error) { |
There was a problem hiding this comment.
Please check that client.DoSyncV2 is called with the correct since tokens.
kegsay
approved these changes
Jul 19, 2023
kegsay
approved these changes
Jul 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Q: should we make the duration configurable?
As per the comments in the code, we store the first since token immediately, after that, either after the last time we stored a token is > 1min OR there are ToDevice messages in the sync response.