Fix lazy-loading test which was looking for the wrong thing #1374
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As the comment says, this test was looking for the wrong thing, and actually enforcing buggy behaviour.
|
Looks like sytest's CI is broken :( |
|
Looks like it is still trying to download the archive from the matrix-org/synapse repository: sytest/.github/workflows/pipeline.yml Line 92 in e2c4b0e |
erikjohnston
approved these changes
Apr 3, 2024
richvdh
added a commit
to element-hq/synapse
that referenced
this pull request
Apr 4, 2024
Unfortunately, the optimisation we applied here for non-gappy syncs is not actually valid. Fixes #16941. ~~Based on #16930 Requires matrix-org/sytest#1374.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As the comment says, this test was looking for the wrong thing, and actually enforcing buggy behaviour.