This repository has been archived by the owner on Mar 19, 2022. It is now read-only.
Gem and doc updates #466
Open
Gem and doc updates #466
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -31,6 +30,6 @@ Gem::Specification.new do |s| | |||
| s.add_development_dependency 'coveralls' | |||
|
|
|||
| s.add_dependency 'chef', '>= 10.20' | |||
| s.add_dependency 'net-ssh', '~> 2.7', '< 3.0' | |||
| s.add_dependency 'erubis', '~> 2.7.0' | |||
| s.add_dependency 'net-ssh', '~> 2.6' | |||
There was a problem hiding this comment.
Chef 12.7.2 declares "net-ssh", ">= 2.9", "< 4.0" in https://github.com/chef/chef/blob/12.7.2/chef.gemspec#L27, could knife-solo, too? Or is there a reason why 2.6 is now declared?
There was a problem hiding this comment.
I suspect at the time it would have been to match other dependencies. But it's been awhile so probably wouldn't hurt to try ">= 2.9", "< 4.0" and see if anything breaks. If you set up the integration test suite (uses EC2 instances) the coverage is pretty comprehensive.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.