-
Notifications
You must be signed in to change notification settings - Fork 82
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: introduces verbosity cli option with foundry-style traces #577
base: main
Are you sure you want to change the base?
Conversation
β¦factor-trace-logs
pub fn build_call_trace_arena( | ||
calls: &[Call], | ||
tx_result: VmExecutionResultAndLogs, | ||
verbosity: u8, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The fact that we pass verbosity here (and if
on verbosity in another file) is a big code smell.
IMHO, this should be handled by the io abstraction only (e.g. we provide the verbosity for the line we want to print, and the shell implementation will decide whether to print it or not).
See #576 (comment) as well
What π»
-vv, -vvv, -vvvv
).Why β
Note: Once discussed / agree, this would ultimately remove the code from
formatter.rs
and simplify the debugging usage inin_memory_inner.rs
which I will have to do incrementally in subsequent PRs.Evidence π·
Include screenshots, screen recordings, or
console
output here demonstrating that your changes work as intendedUsage example:
Trace: