Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: remove tracing::info usage #578

Merged
merged 22 commits into from
Feb 12, 2025
Merged

chore: remove tracing::info usage #578

merged 22 commits into from
Feb 12, 2025

Conversation

dutterbutter
Copy link
Collaborator

@dutterbutter dutterbutter commented Feb 4, 2025 •
edited
Loading

What 💻

  • Turns off tracing::info! in favour of shell wrapper and macro usage. A simplified version of Foundry's shell wrapper.
  • Removes the timestamp for warn, error, debug, trace logs

Why ✋

Evidence 📷

Include screenshots, screen recordings, or console output here demonstrating that your changes work as intended

@dutterbutter dutterbutter marked this pull request as ready for review February 4, 2025 02:05
@dutterbutter dutterbutter requested a review from a team as a code owner February 4, 2025 02:05
@dutterbutter dutterbutter marked this pull request as draft February 4, 2025 13:48
@dutterbutter dutterbutter mentioned this pull request Feb 4, 2025
Open
@dutterbutter dutterbutter mentioned this pull request Feb 4, 2025
Draft
itegulov
itegulov reviewed Feb 6, 2025
View reviewed changes
Cargo.toml Outdated Show resolved Hide resolved
spec-tests/src/patch.rs Outdated Show resolved Hide resolved
crates/common/src/shell.rs Outdated Show resolved Hide resolved
@dutterbutter dutterbutter marked this pull request as ready for review February 6, 2025 16:39
@dutterbutter
Copy link
Collaborator Author

dutterbutter commented Feb 6, 2025 •
edited
Loading

@itegulov based on the proposal feedback, I turned off tracing::info by default, and adjusted some existing log levels. I did so quite arbitrarily so please feel free to suggest changing the level or removing completely. We are still logging out tx summary / console logs by default but intend to update in #577.

For revert / halts and logs in formatter.rs those will be subsequently updated in #571 and #577.

@dutterbutter dutterbutter added the needs review 👓 PR requires a review label Feb 7, 2025
popzxc
popzxc reviewed Feb 10, 2025
View reviewed changes
Copy link
Member

@popzxc popzxc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mostly LGTM

crates/common/Cargo.toml Outdated Show resolved Hide resolved
crates/common/src/shell.rs Outdated Show resolved Hide resolved
crates/core/src/node/eth.rs Outdated Show resolved Hide resolved
itegulov
itegulov requested changes Feb 10, 2025
View reviewed changes
Copy link
Contributor

@itegulov itegulov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good conceptually, some logs were misconverted though IMHO

crates/config/src/config.rs Outdated Show resolved Hide resolved
crates/core/src/formatter.rs Outdated Show resolved Hide resolved
crates/core/src/node/in_memory_ext.rs Outdated Show resolved Hide resolved
crates/core/src/node/inner/blockchain.rs Outdated Show resolved Hide resolved
crates/core/src/node/inner/in_memory_inner.rs Outdated Show resolved Hide resolved
crates/core/src/node/inner/node_executor.rs Outdated Show resolved Hide resolved
crates/core/src/node/pool.rs Outdated Show resolved Hide resolved
crates/core/src/node/zks.rs Show resolved Hide resolved
itegulov
itegulov reviewed Feb 11, 2025
View reviewed changes
Copy link
Contributor

@itegulov itegulov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a few more nits

crates/api_server/src/impls/anvil.rs Outdated Show resolved Hide resolved
crates/config/src/config.rs Outdated Show resolved Hide resolved
crates/core/src/formatter.rs Outdated Show resolved Hide resolved
crates/core/src/node/inner/in_memory_inner.rs Outdated Show resolved Hide resolved
crates/core/src/node/inner/in_memory_inner.rs Outdated Show resolved Hide resolved
@dutterbutter dutterbutter enabled auto-merge (squash) February 11, 2025 22:42
popzxc
popzxc approved these changes Feb 12, 2025
View reviewed changes
Copy link
Member

@popzxc popzxc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mostly LGTM, don't want to block the merge

@dutterbutter dutterbutter merged commit dd18990 into main Feb 12, 2025
13 checks passed
@dutterbutter dutterbutter deleted the db/remove-tracing-info branch February 12, 2025 14:36
@dutterbutter dutterbutter mentioned this pull request Feb 13, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@itegulov itegulov itegulov approved these changes

@popzxc popzxc popzxc approved these changes

Assignees
No one assigned
Labels
needs review 👓 PR requires a review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Refactor: Replace tracing::info! with stdout
3 participants
@dutterbutter @itegulov @popzxc