feat(zk_toolbox): Add holesky testnet as layer1 network #2632
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deniallugo
reviewed
Aug 13, 2024
Deniallugo
approved these changes
Aug 23, 2024
Deniallugo
changed the title
This was referenced Aug 23, 2024
github-merge-queue bot
pushed a commit
that referenced
this pull request
Aug 27, 2024
🤖 I have created a release *beep* *boop* --- ## [24.22.0](core-v24.21.0...core-v24.22.0) (2024-08-27) ### Features * add flag to enable/disable DA inclusion verification ([#2647](#2647)) ([b425561](b425561)) * **Base token:** add cbt metrics ([#2720](#2720)) ([58438eb](58438eb)) * Change default_protective_reads_persistence_enabled to false ([#2716](#2716)) ([8d0eee7](8d0eee7)) * **vm:** Extract oneshot VM executor interface ([#2671](#2671)) ([951d5f2](951d5f2)) * **zk_toolbox:** Add holesky testnet as layer1 network ([#2632](#2632)) ([d9266e5](d9266e5)) ### Bug Fixes * **api:** `tx.gas_price` field ([#2734](#2734)) ([aea3726](aea3726)) * **base_token_adjuster:** bug with a wrong metrics namespace ([#2744](#2744)) ([64b2ff8](64b2ff8)) * **eth-sender:** missing Gateway migration changes ([#2732](#2732)) ([a4170e9](a4170e9)) * **proof_data_handler:** TEE blob fetching error handling ([#2674](#2674)) ([c162510](c162510)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). --------- Co-authored-by: zksync-era-bot <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What ❔
Add
holeskyfor--l1-networkconfig in ecosystem cmd, that will make the testnet use holesky testnet (chain id: 17000) as l1 networkWhy ❔
It can make us deploy testnet into holesky testnet more easy, in zk_inception, it will write the layer1 's chain id into the config, when use
ecosystem initcmd, it will start chain init also, if use wrong chain id for layer1 endpoint, it will make cmd run failed, so we cannot just use layer1 endpoint to deploy a testnet in holesky.Now we add
holeskyfor--l1-networkconfig to let it write 17000 as chain id, that will make us to deploy testnet more easy.Checklist
zk fmtandzk lint.