Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: in-circuit precompiles - modexp, ecadd, ecmul, ecpairing #2851

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

feat: in-circuit precompiles - modexp, ecadd, ecmul, ecpairing #2851

wants to merge 5 commits into from

Conversation

NikitaMasych
Copy link

What ❔

  1. Rewrote ecadd, ecmul, ecpairing to use circuits.
  2. Added modexp which also uses circuits.

Why ❔

Improve performance of EC precompiles and enable Modexp.

Checklist

  • PR title corresponds to the body of PR (we generate changelog entries from PRs).
  • Tests for the changes have been added / updated.
  • Documentation comments have been added / updated.
  • Code has been formatted via zk fmt and zk lint.

@NikitaMasych NikitaMasych force-pushed the dl-precompiles branch 2 times, most recently from 84663e1 to 1ffe993 Compare October 15, 2024 12:21
@NikitaMasych NikitaMasych marked this pull request as ready for review October 17, 2024 12:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
external-contribution
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@NikitaMasych