-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(gateway): refine l2 l1 logs proofs #3078
Changes from all commits
844a37a
82321a1
342fc58
7db7b03
02fc771
7d2df05
576b636
0734aec
278be63
8042aee
481d08e
63e0d49
085d287
a872df7
ab65840
a648594
f86fd0e
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,5 +1,14 @@ | ||
// Position of `FullTree::_height` in `MessageRoot`'s storage layout. | ||
/// Position of `chainCount` in `MessageRoot`'s storage layout. | ||
pub const CHAIN_COUNT_KEY: usize = 0; | ||
|
||
/// Position of `chainIndexToId` in `MessageRoot`'s storage layout. | ||
pub const CHAIN_INDEX_TO_ID_KEY: usize = 2; | ||
|
||
/// Position of `FullTree::_height` in `MessageRoot`'s storage layout. | ||
pub const AGG_TREE_HEIGHT_KEY: usize = 3; | ||
|
||
// Position of `FullTree::nodes` in `MessageRoot`'s storage layout. | ||
/// Position of `FullTree::nodes` in `MessageRoot`'s storage layout. | ||
pub const AGG_TREE_NODES_KEY: usize = 5; | ||
|
||
/// Position of `chainTree` in `MessageRoot`'s storage layout. | ||
pub const CHAIN_TREE_KEY: usize = 7; |
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,2 @@ | ||
ALTER TABLE l1_batches | ||
DROP COLUMN batch_chain_merkle_path BYTEA; |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,5 @@ | ||
ALTER TABLE l1_batches | ||
ADD COLUMN batch_chain_merkle_path BYTEA; | ||
|
||
-- postgres doesn't allow dropping enum variant, so nothing is done in down.sql | ||
ALTER TYPE event_type ADD VALUE 'ChainBatchRoot'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
in case on an emergency if the execute transaction happen outside the eth sender, how hard will it be make this function work?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should be simple: insert corresponding rows to
eth_txs_history
andeth_tx
tables. However, if it happens and server restarts before we insert these rows it potentially can lead to incorrectbatch_chain_merkle_path
being saved. I guess I will add a sanity check to events processor: batch root calculated on eth watcher side should be the same as on SL