Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(zkstack_cli): Rename inception to zkstack #3123

Merged
merged 1 commit into from
Oct 18, 2024

Conversation

manuelmauro
Copy link
Contributor

@manuelmauro manuelmauro commented Oct 17, 2024

What ❔

Rename Inception to ZkStack, and InceptionSubcommands to ZkStackSubcommands.

Why ❔

Checklist

  • PR title corresponds to the body of PR (we generate changelog entries from PRs).
  • Tests for the changes have been added / updated.
  • Documentation comments have been added / updated.
  • Code has been formatted via zkstack dev fmt and zkstack dev lint.

@Deniallugo Deniallugo marked this pull request as ready for review October 17, 2024 15:36
@Deniallugo Deniallugo added this pull request to the merge queue Oct 17, 2024
github-merge-queue bot pushed a commit that referenced this pull request Oct 17, 2024
## What ❔

<!-- What are the changes this PR brings about? -->
<!-- Example: This PR adds a PR template to the repo. -->
<!-- (For bigger PRs adding more context is appreciated) -->
Rename `Inception` to `ZkStack`, and `InceptionSubcommands` to
`ZkStackSubcommands`.

## Why ❔

<!-- Why are these changes done? What goal do they contribute to? What
are the principles behind them? -->
<!-- Example: PR templates ensure PR reviewers, observers, and future
iterators are in context about the evolution of repos. -->

## Checklist

<!-- Check your PR fulfills the following items. -->
<!-- For draft PRs check the boxes as you complete them. -->

- [x] PR title corresponds to the body of PR (we generate changelog
entries from PRs).
- [x] Tests for the changes have been added / updated.
- [x] Documentation comments have been added / updated.
- [x] Code has been formatted via `zkstack dev fmt` and `zkstack dev
lint`.
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to no response for status checks Oct 17, 2024
@Deniallugo Deniallugo added this pull request to the merge queue Oct 18, 2024
Merged via the queue into main with commit 4d283ca Oct 18, 2024
38 checks passed
@Deniallugo Deniallugo deleted the manuel-rename-inception-to-zkstack branch October 18, 2024 10:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants