-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(proof-data-handler): add tee_proof_generation_timeout_in_secs param #3128
Merged
haraldh
merged 4 commits into
main
from
tee/pab/feat-tee-specific-proof-data-handler-timeout
Oct 25, 2024
Merged
feat(proof-data-handler): add tee_proof_generation_timeout_in_secs param #3128
haraldh
merged 4 commits into
main
from
tee/pab/feat-tee-specific-proof-data-handler-timeout
Oct 25, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pbeza
force-pushed
the
tee/pab/feat-tee-specific-proof-data-handler-timeout
branch
from
October 18, 2024 14:54
41d0c85
to
88edd26
Compare
Perhaps I should extract the TEE-specific options, like I did in #3112 (which hasn't been merged yet): zksync-era/core/lib/config/src/configs/proof_data_handler.rs Lines 6 to 22 in 6f0b18e
Lemme know what's your preference, @haraldh @slowli. In case you wondered what is
EditUpdated. ✅ |
pbeza
force-pushed
the
tee/pab/feat-tee-specific-proof-data-handler-timeout
branch
5 times, most recently
from
October 24, 2024 15:38
6fbc503
to
0a495d4
Compare
Add `tee_proof_generation_timeout_in_secs` parameter to the `proof-data-handler` configuration to avoid sharing the same `proof_generation_timeout_in_secs` timeout with the prover. This timeout is for retrying TEE proof generation if it fails. Retries continue indefinitely until successful.
pbeza
force-pushed
the
tee/pab/feat-tee-specific-proof-data-handler-timeout
branch
from
October 25, 2024 08:31
0a495d4
to
952b50d
Compare
haraldh
previously approved these changes
Oct 25, 2024
…ific-proof-data-handler-timeout
slowli
previously approved these changes
Oct 25, 2024
…ific-proof-data-handler-timeout
haraldh
approved these changes
Oct 25, 2024
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Oct 25, 2024
haraldh
deleted the
tee/pab/feat-tee-specific-proof-data-handler-timeout
branch
October 25, 2024 14:33
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What ❔
Add
tee_proof_generation_timeout_in_secs
parameter to theproof-data-handler
configuration to avoid sharing the sameproof_generation_timeout_in_secs
timeout with the ZK prover.This timeout is for retrying TEE proof generation if it fails. Retries continue indefinitely until successful.
Why ❔
The TEE prover is much faster than the ZK prover, so some of the ZK timeouts are too long to be shared with the TEE-specific code.
Checklist
zkstack dev fmt
andzkstack dev lint
.