Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(vm): Support EVM emulation in fast VM #3163

Merged
merged 10 commits into from
Oct 31, 2024
Merged

feat(vm): Support EVM emulation in fast VM #3163

merged 10 commits into from
Oct 31, 2024

Conversation

slowli
Copy link
Contributor

@slowli slowli commented Oct 23, 2024

What ❔

Supports EVM emulation if it is signaled via SystemEnv.

Why ❔

Fast VM should have feature parity with the legacy VM.

Checklist

  • PR title corresponds to the body of PR (we generate changelog entries from PRs).
  • Tests for the changes have been added / updated.
  • Documentation comments have been added / updated.
  • Code has been formatted via zkstack dev fmt and zkstack dev lint.

@slowli slowli marked this pull request as ready for review October 24, 2024 06:13
joonazan
joonazan reviewed Oct 28, 2024
View reviewed changes
Copy link
Contributor

@joonazan joonazan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I did not review the tests. The VM changes look good.

core/lib/multivm/src/versions/vm_fast/evm_deploy_tracer.rs Outdated Show resolved Hide resolved
core/lib/multivm/src/versions/vm_fast/evm_deploy_tracer.rs Outdated Show resolved Hide resolved
core/lib/multivm/src/versions/vm_fast/vm.rs Outdated Show resolved Hide resolved
core/lib/multivm/src/versions/vm_fast/vm.rs Outdated Show resolved Hide resolved
perekopskiy
perekopskiy previously approved these changes Oct 31, 2024
View reviewed changes
core/lib/multivm/src/versions/vm_fast/vm.rs Show resolved Hide resolved
@slowli slowli enabled auto-merge October 31, 2024 13:13
@slowli slowli added this pull request to the merge queue Oct 31, 2024
Merged via the queue into main with commit 9ad1f0d Oct 31, 2024
33 checks passed
@slowli slowli deleted the aov-evm-792-support-evm-emulation-in-fast-vm branch October 31, 2024 14:45
@zksync-era-bot zksync-era-bot mentioned this pull request Oct 31, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@perekopskiy perekopskiy perekopskiy approved these changes

@Deniallugo Deniallugo Awaiting requested review from Deniallugo

@0xVolosnikov 0xVolosnikov Awaiting requested review from 0xVolosnikov

@joonazan joonazan Awaiting requested review from joonazan

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@slowli @joonazan @perekopskiy