fix: return min refund when gas_price=0 #3363
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dimazhornyk
requested review from
ischasny,
vladbochok and
StanislavBreadless
| @@ -116,6 +116,9 @@ impl<S> RefundsTracer<S> { | |||
|
|
|||
| // For now, bootloader charges only for base fee. | |||
| let effective_gas_price = get_batch_base_fee(&self.l1_batch); | |||
| if effective_gas_price == 0 { | |||
There was a problem hiding this comment.
Talked in private: it is a breaking change, but most likely it is fine. Still, it is better to be able to somehow check that the partners (and Era itself) are not affected
There was a problem hiding this comment.
- What if we safeguard it behind a feature toggle?
- What is the scenario that we need to check for?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What ❔
Return the minimal possible refund when
effective_gas_price=0to avoid division by zeroWhy ❔
When we set the gas fees to zero, the execution breaks at this point due to division by zero
Checklist
zkstack dev fmtandzkstack dev lint.