MM-60233 - fix issue in kde of focus after minimize #3157
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
larkox
approved these changes
Oct 4, 2024
devinbinnie
requested changes
Oct 4, 2024
devinbinnie
reviewed
Oct 15, 2024
devinbinnie
reviewed
Oct 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
MM-60233: Fix window minimizing issue on KDE/KWin environments. The app window was immediately being focus after being minimized, and it caused it to restore instead of stay minimized. This happened because the onFocus event was being triggered after minimizing, and then the actions within the onFocus handler was causing the window to re obtain the focus.
This PR resolves this by modifying the onFocus event handler by checking if the application was running on KDE/KWin (plasma) and if the window is also minimized. If both of the conditions are present, then the handler will return early and will not execute further actions avoiding the window to obtain focus unwanted.
Ticket Link
https://mattermost.atlassian.net/browse/MM-60233
Closes #3130
Checklist
npm run lint:jsfor proper code formattingRun Desktop E2E TestsDevice Information
This PR was tested on:
Kubuntu:
Operating System: Kubuntu 24.04
KDE Plasma Version: 5.27.11
KDE Frameworks Version: 5.115.0
Qt Version: 5.15.13
Kernel Version: 6.8.0-45-generic (64-bit)
Graphics Platform: X11
Processors: 2
Memory: 1.9 GiB of RAM
Graphics Processor: virgl
Manufacturer: Parallels International GmbH.
Product Name: Parallels ARM Virtual Machine
System Version: 0.1
Screenshots
Before:
Screen.Recording.2024-10-03.at.22.28.39.mov
After:
Screen.Recording.2024-10-03.at.22.23.38.mov
Release Note