Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Snyk] Upgrade playwright from 1.49.1 to 1.50.0 #3335

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

mm-prodsec-bot
Copy link
Contributor

snyk-top-banner

Snyk has created this PR to upgrade playwright from 1.49.1 to 1.50.0.

ℹ️ Keep your dependencies up-to-date. This makes it easier to fix existing vulnerabilities and to more quickly identify and fix newly disclosed vulnerabilities when they affect your project.


  • The recommended version is 94 versions ahead of your current version.

  • The recommended version was released 23 days ago.

Release notes
Package name: playwright
  • 1.50.0 - 2025-01-23

    Test runner

    • New option timeout allows specifying a maximum run time for an individual test step. A timed-out step will fail the execution of the test.

      test('some test', async ({ page }) => {
        await test.step('a step', async () => {
          // This step can time out separately from the test
        }, { timeout: 1000 });
      });
    • New method test.step.skip() to disable execution of a test step.

      test('some test', async ({ page }) => {
      await test.step('before running step', async () => {
      // Normal step
      });

      await test.step.skip('not yet ready', async () => {
      // This step is skipped
      });

      await test.step('after running step', async () => {
      // This step still runs even though the previous one was skipped
      });
      });

    • Expanded expect(locator).toMatchAriaSnapshot() to allow storing of aria snapshots in separate YAML files.

    • Added method expect(locator).toHaveAccessibleErrorMessage() to assert the Locator points to an element with a given aria errormessage.

    • Option testConfig.updateSnapshots added the configuration enum changed. changed updates only the snapshots that have changed, whereas all now updates all snapshots, regardless of whether there are any differences.

    • New option testConfig.updateSourceMethod defines the way source code is updated when testConfig.updateSnapshots is configured. Added overwrite and 3-way modes that write the changes into source code, on top of existing patch mode that creates a patch file.

      npx playwright test --update-snapshots=changed --update-source-method=3way
    • Option testConfig.webServer added a gracefulShutdown field for specifying a process kill signal other than the default SIGKILL.

    • Exposed testStep.attachments from the reporter API to allow retrieval of all attachments created by that step.

    • New option pathTemplate for toHaveScreenshot and toMatchAriaSnapshot assertions in the testConfig.expect configuration.

    UI updates

    • Updated default HTML reporter to improve display of attachments.
    • New button for picking elements to produce aria snapshots.
    • Additional details (such as keys pressed) are now displayed alongside action API calls in traces.
    • Display of canvas content in traces is error-prone. Display is now disabled by default, and can be enabled via the Display canvas content UI setting.
    • Call and Network panels now display additional time information.

    Breaking

    Browser Versions

    • Chromium 133.0.6943.16
    • Mozilla Firefox 134.0
    • WebKit 18.2

    This version was also tested against the following stable channels:

    • Google Chrome 132
    • Microsoft Edge 132
  • 1.50.0-beta-1738269400000 - 2025-01-30
  • 1.50.0-beta-1738267712000 - 2025-01-30
  • 1.50.0-beta-1738240825000 - 2025-01-30
  • 1.50.0-beta-1738235262000 - 2025-01-30
  • 1.50.0-beta-1738199921000 - 2025-01-30
  • 1.50.0-beta-1738167398000 - 2025-01-29
  • 1.50.0-beta-1738167361000 - 2025-01-29
  • 1.50.0-beta-1738162324000 - 2025-01-29
  • 1.50.0-beta-1738148461000 - 2025-01-29
  • 1.50.0-beta-1738116015000 - 2025-01-29
  • 1.50.0-beta-1738109212000 - 2025-01-29
  • 1.50.0-beta-1738103953000 - 2025-01-28
  • 1.50.0-beta-1738058149000 - 2025-01-28
  • 1.50.0-beta-1737762224000 - 2025-01-24
  • 1.50.0-beta-1737749840000 - 2025-01-24
  • 1.50.0-beta-1737639506000 - 2025-01-23
  • 1.50.0-beta-1737637449000 - 2025-01-23
  • 1.50.0-beta-1737629780000 - 2025-01-23
  • 1.50.0-beta-1737569167000 - 2025-01-22
  • 1.50.0-beta-1737568569000 - 2025-01-22
  • 1.50.0-beta-1737557690000 - 2025-01-22
  • 1.50.0-beta-1737538027000 - 2025-01-22
  • 1.50.0-beta-1737532416000 - 2025-01-22
  • 1.50.0-beta-1737532333000 - 2025-01-22
  • 1.50.0-beta-1737179657000 - 2025-01-18
  • 1.50.0-beta-1737153401000 - 2025-01-17
  • 1.50.0-beta-1737137869000 - 2025-01-17
  • 1.50.0-beta-1731498714000 - 2024-11-13
  • 1.50.0-alpha-2025-01-17 - 2025-01-17
  • 1.50.0-alpha-2025-01-16 - 2025-01-16
  • 1.50.0-alpha-2025-01-15 - 2025-01-15
  • 1.50.0-alpha-2025-01-14 - 2025-01-14
  • 1.50.0-alpha-2025-01-13 - 2025-01-13
  • 1.50.0-alpha-2025-01-12 - 2025-01-12
  • 1.50.0-alpha-2025-01-11 - 2025-01-11
  • 1.50.0-alpha-2025-01-07 - 2025-01-07
  • 1.50.0-alpha-2025-01-06 - 2025-01-06
  • 1.50.0-alpha-2025-01-05 - 2025-01-05
  • 1.50.0-alpha-2025-01-04 - 2025-01-04
  • 1.50.0-alpha-2025-01-03 - 2025-01-03
  • 1.50.0-alpha-2025-01-02 - 2025-01-02
  • 1.50.0-alpha-2025-01-01 - 2025-01-01
  • 1.50.0-alpha-2024-12-31 - 2024-12-31
  • 1.50.0-alpha-2024-12-30 - 2024-12-30
  • 1.50.0-alpha-2024-12-29 - 2024-12-29
  • 1.50.0-alpha-2024-12-28 - 2024-12-28
  • 1.50.0-alpha-2024-12-27 - 2024-12-27
  • 1.50.0-alpha-2024-12-26 - 2024-12-26
  • 1.50.0-alpha-2024-12-25 - 2024-12-25
  • 1.50.0-alpha-2024-12-24 - 2024-12-24
  • 1.50.0-alpha-2024-12-23 - 2024-12-23
  • 1.50.0-alpha-2024-12-22 - 2024-12-22
  • 1.50.0-alpha-2024-12-21 - 2024-12-21
  • 1.50.0-alpha-2024-12-20 - 2024-12-20
  • 1.50.0-alpha-2024-12-19 - 2024-12-19
  • 1.50.0-alpha-2024-12-18 - 2024-12-18
  • 1.50.0-alpha-2024-12-17 - 2024-12-17
  • 1.50.0-alpha-2024-12-16 - 2024-12-16
  • 1.50.0-alpha-2024-12-15 - 2024-12-15
  • 1.50.0-alpha-2024-12-14 - 2024-12-14
  • 1.50.0-alpha-2024-12-13 - 2024-12-13
  • 1.50.0-alpha-2024-12-12 - 2024-12-12
  • 1.50.0-alpha-2024-12-11 - 2024-12-11
  • 1.50.0-alpha-2024-12-10 - 2024-12-10
  • 1.50.0-alpha-2024-12-09 - 2024-12-09
  • 1.50.0-alpha-2024-12-08 - 2024-12-08
  • 1.50.0-alpha-2024-12-07 - 2024-12-07
  • 1.50.0-alpha-2024-12-06 - 2024-12-06
  • 1.50.0-alpha-2024-12-05 - 2024-12-05
  • 1.50.0-alpha-2024-12-04 - 2024-12-04
  • 1.50.0-alpha-2024-12-03 - 2024-12-03
  • 1.50.0-alpha-2024-12-02 - 2024-12-02
  • 1.50.0-alpha-2024-12-01 - 2024-12-01
  • 1.50.0-alpha-2024-11-30 - 2024-11-30
  • 1.50.0-alpha-2024-11-29 - 2024-11-29
  • 1.50.0-alpha-2024-11-28 - 2024-11-28
  • 1.50.0-alpha-2024-11-27 - 2024-11-27
  • 1.50.0-alpha-2024-11-26 - 2024-11-26
  • 1.50.0-alpha-2024-11-25 - 2024-11-25
  • 1.50.0-alpha-2024-11-24 - 2024-11-24
  • 1.50.0-alpha-2024-11-23 - 2024-11-23
  • 1.50.0-alpha-2024-11-22 - 2024-11-22
  • 1.50.0-alpha-2024-11-21 - 2024-11-21
  • 1.50.0-alpha-2024-11-20 - 2024-11-20
  • 1.50.0-alpha-2024-11-19 - 2024-11-19
  • 1.50.0-alpha-2024-11-18 - 2024-11-18
  • 1.50.0-alpha-2024-11-17 - 2024-11-17
  • 1.50.0-alpha-2024-11-16 - 2024-11-16
  • 1.50.0-alpha-2024-11-15 - 2024-11-15
  • 1.50.0-alpha-2024-11-14 - 2024-11-14
  • 1.50.0-alpha-1737075373000 - 2025-01-17
  • 1.50.0-alpha-1737068696000 - 2025-01-16
  • 1.50.0-alpha-1736502759000 - 2025-01-10
  • 1.49.1 - 2024-12-10

    Highlights

    #33802 - [Bug]: Codegen's Clear button doesn't work if not recording
    #33806 - [Bug]: playwright hangs while waiting for pending navigations
    #33787 - [Bug]: VSC extension isn't capturing all entered text
    #33788 - [Regression]: Double clicking the steps in trace viewer doesn't filter actions
    #33772 - [Bug]: aria_snapshot generates invalid yaml when combined with an aria-label attribut
    #33791 - [Bug]: text input with number value raises "container is not iterable" with to_match_aria_snapshot
    #33644 - [Bug]: getByRole can't find element with the accessible name from label element when aria-labelledby is not valid
    #33660 - [Regression]: Unable to open Playwright UI in Dark Mode

    Browser Versions

    • Chromium 131.0.6778.33
    • Mozilla Firefox 132.0
    • WebKit 18.2

    This version was also tested against the following stable channels:

    • Google Chrome 130
    • Microsoft Edge 130
from playwright GitHub release notes

Important

  • Check the changes in this PR to ensure they won't cause issues with your project.
  • This PR was automatically created by Snyk using the credentials of a real user.

Note: You are seeing this because you or someone else with access to this repository has authorized Snyk to open upgrade PRs.

For more information:

Snyk has created this PR to upgrade playwright from 1.49.1 to 1.50.0.

See this package in npm:
playwright

See this project in Snyk:
https://app.snyk.io/org/mattermost-core/project/3dea6042-a212-4359-aa52-4b8845ec1c35?utm_source=github-enterprise&utm_medium=referral&page=upgrade-pr
@mm-cloud-bot
Copy link

@mm-prodsec-bot: Adding the "do-not-merge/release-note-label-needed" label because no release-note block was detected, please follow our release note process to remove it.

I understand the commands that are listed here

@yasserfaraazkhan yasserfaraazkhan added the Run Desktop E2E Tests This label will trigger the workflow that runs e2e automation tests label Feb 15, 2025
Copy link

Here are the test results below:

Test Summary for Linux on commit 0671cb0

New failed tests found on Linux:

  • dark_mode MM-T2465 Linux Dark Mode Toggle

Test Summary for macOS on commit 0671cb0

New failed tests found on macOS:

  • Trigger Notification From desktop should receive a notification on macOS

Test Summary for Windows on commit 0671cb0

New failed tests found on Windows:

  • downloads/downloads_menubar The download list has one file MM-22239 should show the downloads dropdown button and the menu item should be enabled
  • downloads/downloads_menubar The download list has one file MM-22239 should open the downloads dropdown when clicking the download button in the menubar
  • copylink MM-T125 Copy Link can be used from channel LHS
  • menu_bar/dropdown MM-T4405 should set name of menu item from config file
  • menu_bar/dropdown MM-T4407 should open the new server prompt after clicking the add button
  • menu_bar/dropdown MM-T4408 Switch Servers MM-T4408_1 should show the first view
  • menu_bar/dropdown MM-T4408 Switch Servers MM-T4408_2 should show the second view after clicking the menu item
  • file_menu/dropdown MM-T805 Sign in to Another Server Window opens using menu item
  • history_menu Click back and forward from history
  • menu/menu MM-T4404 should open the 3 dot menu with Alt
  • menu/view MM-T813 Control+F should focus the search bar in Mattermost
  • menu/view MM-T817 Actual Size Zoom in the menu bar
  • menu/view MM-T818 Zoom in from the menu bar MM-T818_1 Zoom in when CmdOrCtrl+Plus is pressed
  • menu/view MM-T818 Zoom in from the menu bar MM-T818_2 Zoom in when CmdOrCtrl+Shift+Plus is pressed
  • menu/view MM-T819 Zoom out from the menu bar MM-T819_1 Zoom out when CmdOrCtrl+Minus is pressed
  • menu/view MM-T819 Zoom out from the menu bar MM-T819_2 Zoom out when CmdOrCtrl+Shift+Minus is pressed
  • Menu/window_menu MM-T827 select next/previous tab
  • Menu/window_menu MM-T824 should be minimized when keyboard shortcuts are pressed
  • Menu/window_menu MM-T825 should be hidden when keyboard shortcuts are pressed
  • Menu/window_menu MM-T4385 select tab from menu MM-T4385_1 should show the second tab
  • Menu/window_menu MM-T4385 select tab from menu MM-T4385_2 should show the third tab
  • Menu/window_menu MM-T4385 select tab from menu MM-T4385_3 should show the first tab
  • copylink MM-T1308 Check that external links dont open in the app
  • Configure Server Modal MM-T5119 should add the server to the config file
  • server_management/drag_and_drop MM-T2634 should be able to drag and drop servers in the dropdown menu MM-T2634_1 should appear the original order
  • server_management/drag_and_drop MM-T2634 should be able to drag and drop servers in the dropdown menu MM-T2634_2 after dragging the server down, should appear in the new order
  • server_management/drag_and_drop MM-T2634 should be able to drag and drop servers in the dropdown menu MM-T2634_3 should update the config file
  • server_management/drag_and_drop MM-T2635 should be able to drag and drop tabs MM-T2635_1 should be in the original order
  • server_management/drag_and_drop MM-T2635 should be able to drag and drop tabs MM-T2635_2 after moving the tab to the right, the tab should be in the new order
  • server_management/drag_and_drop MM-T2635 should be able to drag and drop tabs MM-T2635_3 should update the config file
  • EditServerModal MM-T4391_2 should edit server when Save is pressed and name edited
  • EditServerModal MM-T4391_3 should edit server when Save is pressed and URL edited
  • EditServerModal MM-T4391_4 should edit server when Save is pressed and both edited
  • header MM-T2637 Double-Clicking on the header should minimize/maximize the app MM-T2637_2 should restore on double-clicking the header when maximized
  • RemoveServerModal MM-T4390_1 should remove existing server on click Remove
  • Settings Options Check spelling MM-T4397 should appear and be selectable
  • Settings Options Enable GPU hardware acceleration MM-T4398 should save selected option
  • Settings Options Enable automatic check for updates MM-T4549 should save selected option
  • startup/app MM-T4975 should show the welcome screen modal when no servers exist
  • startup/app MM-T4985 should show app name in title bar when no servers exist
  • config MM-T4402 should upgrade v0 config file
  • config MM-T4401 should show servers in dropdown when there is config file MM-T4401_1 should show correct server in the dropdown button
  • config MM-T4401 should show servers in dropdown when there is config file MM-T4401_2 should set src of browser view from config file
  • Welcome Screen Modal MM-T4976 should show the slides in the expected order
  • Welcome Screen Modal MM-T4977 should be able to move through slides clicking the navigation buttons
  • Welcome Screen Modal MM-T4978 should be able to move through slides clicking the pagination indicator
  • Welcome Screen Modal MM-T4979 should be able to move forward through slides automatically every 5 seconds
  • Welcome Screen Modal MM-T4980 should show the slides in the expected order
  • Welcome Screen Modal MM-T4981 should be able to move from last to first slide
  • Welcome Screen Modal MM-T4982 should be able to move from first to last slide
  • Welcome Screen Modal MM-T4983 should be able to click the get started button and be redirected to new server modal
  • window MM-T4403_1 should restore window bounds

@github-actions github-actions bot removed the Run Desktop E2E Tests This label will trigger the workflow that runs e2e automation tests label Feb 15, 2025
@yasserfaraazkhan
Copy link
Contributor

@devinbinnie
can you help with this? On windos the app.evaluate doesnt return the context. It looks like similar the error you had fixed.

@devinbinnie
Copy link
Member

@devinbinnie can you help with this? On windos the app.evaluate doesnt return the context. It looks like similar the error you had fixed.

I can't reproduce this locally, it might be that the runner is having issues running the tests. I'm seeing a lot of other failures unrelated to that issue.

@devinbinnie
Copy link
Member

@yasserfaraazkhan As a follow-up, those Windows tests seem to be failing in other PRs, so it's more than likely the runner.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants