-
Notifications
You must be signed in to change notification settings - Fork 860
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Snyk] Upgrade playwright from 1.49.1 to 1.50.0 #3335
base: master
Are you sure you want to change the base?
[Snyk] Upgrade playwright from 1.49.1 to 1.50.0 #3335
Conversation
Snyk has created this PR to upgrade playwright from 1.49.1 to 1.50.0. See this package in npm: playwright See this project in Snyk: https://app.snyk.io/org/mattermost-core/project/3dea6042-a212-4359-aa52-4b8845ec1c35?utm_source=github-enterprise&utm_medium=referral&page=upgrade-pr
@mm-prodsec-bot: Adding the "do-not-merge/release-note-label-needed" label because no release-note block was detected, please follow our release note process to remove it. I understand the commands that are listed here |
Here are the test results below: Test Summary for Linux on commit 0671cb0New failed tests found on Linux:
Test Summary for macOS on commit 0671cb0New failed tests found on macOS:
Test Summary for Windows on commit 0671cb0New failed tests found on Windows:
|
@devinbinnie |
I can't reproduce this locally, it might be that the runner is having issues running the tests. I'm seeing a lot of other failures unrelated to that issue. |
@yasserfaraazkhan As a follow-up, those Windows tests seem to be failing in other PRs, so it's more than likely the runner. |
Snyk has created this PR to upgrade playwright from 1.49.1 to 1.50.0.
ℹ️ Keep your dependencies up-to-date. This makes it easier to fix existing vulnerabilities and to more quickly identify and fix newly disclosed vulnerabilities when they affect your project.
The recommended version is 94 versions ahead of your current version.
The recommended version was released 23 days ago.
Release notes
Package name: playwright
Test runner
New option
timeout
allows specifying a maximum run time for an individual test step. A timed-out step will fail the execution of the test.New method test.step.skip() to disable execution of a test step.
await test.step('before running step', async () => {
// Normal step
});
await test.step.skip('not yet ready', async () => {
// This step is skipped
});
await test.step('after running step', async () => {
// This step still runs even though the previous one was skipped
});
});
Expanded expect(locator).toMatchAriaSnapshot() to allow storing of aria snapshots in separate YAML files.
Added method expect(locator).toHaveAccessibleErrorMessage() to assert the Locator points to an element with a given aria errormessage.
Option testConfig.updateSnapshots added the configuration enum
changed
.changed
updates only the snapshots that have changed, whereasall
now updates all snapshots, regardless of whether there are any differences.New option testConfig.updateSourceMethod defines the way source code is updated when testConfig.updateSnapshots is configured. Added
overwrite
and3-way
modes that write the changes into source code, on top of existingpatch
mode that creates a patch file.npx playwright test --update-snapshots=changed --update-source-method=3way
Option testConfig.webServer added a
gracefulShutdown
field for specifying a process kill signal other than the defaultSIGKILL
.Exposed testStep.attachments from the reporter API to allow retrieval of all attachments created by that step.
New option
pathTemplate
fortoHaveScreenshot
andtoMatchAriaSnapshot
assertions in the testConfig.expect configuration.UI updates
canvas
content in traces is error-prone. Display is now disabled by default, and can be enabled via theDisplay canvas content
UI setting.Call
andNetwork
panels now display additional time information.Breaking
<input>
,<select>
, or a number of other editable elements.all
, rather than only the failed/changed snapshots. Use the new enumchanged
to keep the old functionality of only updating the changed snapshots.Browser Versions
This version was also tested against the following stable channels:
Highlights
#33802 - [Bug]: Codegen's Clear button doesn't work if not recording
#33806 - [Bug]: playwright hangs while waiting for pending navigations
#33787 - [Bug]: VSC extension isn't capturing all entered text
#33788 - [Regression]: Double clicking the steps in trace viewer doesn't filter actions
#33772 - [Bug]: aria_snapshot generates invalid yaml when combined with an aria-label attribut
#33791 - [Bug]: text input with number value raises "container is not iterable" with to_match_aria_snapshot
#33644 - [Bug]: getByRole can't find element with the accessible name from label element when aria-labelledby is not valid
#33660 - [Regression]: Unable to open Playwright UI in Dark Mode
Browser Versions
This version was also tested against the following stable channels:
Important
Note: You are seeing this because you or someone else with access to this repository has authorized Snyk to open upgrade PRs.
For more information: